From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Sat, 06 Jan 2024 10:58:36 +0200 Message-ID: <83mstiu9c3.fsf@gnu.org> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> <875y4oaban.fsf@whxvd.name> <83bkeg4o1u.fsf@gnu.org> <87o7ifu2v8.fsf@localhost> <838r9j339x.fsf@gnu.org> <87tts78lve.fsf@whxvd.name> <87zg1u0yrp.fsf@whxvd.name> <8334zmrmnu.fsf@gnu.org> <87o7eew0is.fsf@whxvd.name> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="646"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, 65734@debbugs.gnu.org To: Sebastian Miele , Stefan Monnier , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 06 09:59:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rM2WN-000AXP-0c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jan 2024 09:59:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rM2WB-0000KY-EM; Sat, 06 Jan 2024 03:58:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rM2W9-0000K6-AQ for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 03:58:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rM2W9-0004ya-2Q for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 03:58:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rM2WD-0004Ry-RZ for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 03:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jan 2024 08:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.170453153817097 (code B ref 65734); Sat, 06 Jan 2024 08:59:01 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 6 Jan 2024 08:58:58 +0000 Original-Received: from localhost ([127.0.0.1]:58534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rM2WA-0004Rg-5K for submit@debbugs.gnu.org; Sat, 06 Jan 2024 03:58:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rM2W8-0004RS-CP for 65734@debbugs.gnu.org; Sat, 06 Jan 2024 03:58:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rM2Vx-0004xS-Sh; Sat, 06 Jan 2024 03:58:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DCdmy3OUJketNIUnu0WDHXcWt9YUiTstTQbwdbB61eU=; b=R/Sm1DkaPq9d FqwwBBZySQ1Li6R4gphFedQHoNpasob6RQx3TFHsR7kmDCEO8uOOvjqUk8uI+EMvY9nmJuu9swP5r YdEUh2BCi53tTrmNDAM8sgTLWVBR/nzrS0yGr48OmtNm2UiKoJuhvLdLOOhLbpI7aOdRczzkzcTY8 v4B5kK3qQW0eXf3ObwZq5LptejAnjxlxmV5oIBD98YI1suV2nDgdvCOew8QgKaKls7K/xgt6zFsxb WN3IKoMiqBKlfcaJjnJJyaQCCRT5IBQ+E2qNnr2ZpjEBR+uvta85qw7r4XNnw4zM/fyFdtCaFOr4z wCyZyPGusx5PQPYWGjnBBw==; In-Reply-To: <87o7eew0is.fsf@whxvd.name> (message from Sebastian Miele on Mon, 25 Dec 2023 19:53:36 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277437 Archived-At: > From: Sebastian Miele > Cc: 65734@debbugs.gnu.org, yantar92@posteo.net > Date: Mon, 25 Dec 2023 19:53:36 +0100 > > Attached are two patches. The first patch introduces the tests, > including two tests that are expected to be failing for the current > `kill-whole-line'. > > The test `kill-whole-line-read-only' does not fail because of the bug > reported in this bug report, but because of another bug that I stumbled > upon while investigating and testing: `kill-whole-line' always kills by > two calls to `kill-region'. When the buffer is readonly, the first of > the two calls to `kill-region' errors out / exits non-locally. That > causes `kill-region' to omit to put the remaining stuff (from the second > `kill-region') into the kill ring. > > The second patch fixes both bugs, and removes the corresponding > `:expected-result :failed' from the tests. Thanks. The patches lack suitable ChangeLog-style commit log messages (see CONTRIBUTE for details and you can use "git log" to show examples of how we do this). I'd also ask Stefan Monnier and Stefan Kangas to review the patch, since this is an important command and I would like to avoid breaking it.