From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] GnuTLS support on Woe32 Date: Tue, 03 May 2011 19:47:11 +0300 Message-ID: <83liyn4tps.fsf@gnu.org> References: <87ipvwl1nx.wl%claudio.bley@gmail.com> <87wrjquacf.fsf@lifelogs.com> <87lj05svwh.fsf@lifelogs.com> <87bp11imgb.wl%claudio.bley@gmail.com> <8739mc5nes.fsf@lifelogs.com> <87ipuubao6.fsf@lifelogs.com> <87fwpjfkkz.fsf@lifelogs.com> <87bp072fb1.fsf@lifelogs.com> <874o5vimm5.fsf@lifelogs.com> <87zknjmcyk.fsf@lifelogs.com> <87sjta2zvp.fsf@lifelogs.com> <87liyzglkh.fsf@lifelogs.com> <4DB77682.1070605@gmail.com> <8762q04ba1.fsf@lifelogs.com> <87hb9dufao.fsf@lifelogs.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: dough.gmane.org 1304441255 14042 80.91.229.12 (3 May 2011 16:47:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 3 May 2011 16:47:35 +0000 (UTC) Cc: tzz@lifelogs.com, emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 03 18:47:31 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QHIl0-0006r1-BO for ged-emacs-devel@m.gmane.org; Tue, 03 May 2011 18:47:30 +0200 Original-Received: from localhost ([::1]:44611 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHIkz-00019f-MM for ged-emacs-devel@m.gmane.org; Tue, 03 May 2011 12:47:29 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:58557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHIkw-00019L-MS for emacs-devel@gnu.org; Tue, 03 May 2011 12:47:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHIkv-0007rj-IX for emacs-devel@gnu.org; Tue, 03 May 2011 12:47:26 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:46309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHIkv-0007rV-6r for emacs-devel@gnu.org; Tue, 03 May 2011 12:47:25 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LKM00000P859100@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Tue, 03 May 2011 19:47:06 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.228.185.101]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKM00MLKPAGOL80@a-mtaout22.012.net.il>; Tue, 03 May 2011 19:47:06 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139056 Archived-At: > From: Juanma Barranquero > Date: Tue, 3 May 2011 12:01:17 +0200 > Cc: tzz@lifelogs.com, emacs-devel@gnu.org >=20 > On Tue, May 3, 2011 at 06:19, Eli Zaretskii wrote: >=20 > > However, this: > > > >> +#include "lisp.h" > > > > is bad: lisp.h is already included in too many places. =C2=A0Why = did you > > need this? >=20 > Because of Lisp_Object. The alternative would be to put Vlibrary_ca= che > and w32_delayed_load in another module. ?? But we have gobs of other headers that use Lisp_Object, and none o= f them includes lisp.h. We simply should be careful to include lisp.h before everything else, including w32.h. Doesn't that work for you? > > =C2=A0. it should describe the structure of the LIBRARIES alist e= xplicitly, > > =C2=A0 like you'd do in a doc string, not just refer to > > =C2=A0 `dynamic-library-alist' > > > > . it says nothing about the second argument (and IIUC what it me= ans, > > the "_id" part of the variable name is misleading) >=20 > IIRC, I just moved the code from image.c to here and renamed the > variables. Yes, I know. I thought it was good to clean it up a bit while you ar= e at that. But if you want to leave fixing this to another rainy day, = I will understand. Thanks.