From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: lekktu@gmail.com, emacs-devel@gnu.org
Subject: Re: Changes in update-game-score.c
Date: Fri, 24 Jan 2014 09:34:39 +0200 [thread overview]
Message-ID: <83lhy5ests.fsf@gnu.org> (raw)
In-Reply-To: <52E18EC0.7090302@cs.ucla.edu>
> Date: Thu, 23 Jan 2014 13:50:56 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> Cc: Emacs developers <emacs-devel@gnu.org>
>
> For example, if we look at a recent simple patch (attached), it's
> actually two changes, one change for each variable that was declared
> on WINDOWSNT platforms but not used there.
Alternatively, one could say in the log something like "Avoid compiler
warnings due to unused variables."
In any case, the comparison is invalid because this change wasn't
fixing any bug, it's more like whitespace cleanup.
> The situation for update-game-score was similar, and this is true of
> many changes we make to Emacs.
True or false, sumo changesets make maintenance harder, e.g., because
they cannot be reverted easily.
next prev parent reply other threads:[~2014-01-24 7:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 19:42 Changes in update-game-score.c Eli Zaretskii
2014-01-22 19:50 ` David Kastrup
2014-01-22 20:07 ` Eli Zaretskii
2014-01-22 20:10 ` David Kastrup
2014-01-23 1:51 ` Glenn Morris
2014-01-23 3:33 ` Paul Eggert
2014-01-23 3:53 ` Eli Zaretskii
2014-01-23 16:02 ` Eli Zaretskii
2014-01-23 3:58 ` Glenn Morris
2014-01-23 3:32 ` Paul Eggert
2014-01-23 3:52 ` Eli Zaretskii
2014-01-23 3:59 ` Glenn Morris
2014-01-23 4:30 ` Glenn Morris
2014-01-23 4:33 ` Glenn Morris
2014-01-23 4:56 ` Paul Eggert
2014-01-23 16:07 ` Eli Zaretskii
2014-01-23 18:18 ` Paul Eggert
2014-01-23 20:27 ` Juanma Barranquero
2014-01-23 21:50 ` Paul Eggert
2014-01-23 22:39 ` Juanma Barranquero
2014-01-24 7:34 ` Eli Zaretskii [this message]
2014-01-24 8:42 ` Paul Eggert
2014-01-24 9:17 ` Eli Zaretskii
2014-01-24 15:29 ` Jarek Czekalski
2014-01-24 15:40 ` Eli Zaretskii
2014-01-24 15:42 ` change the Subject line when you change topics [was: Changes in update-game-score.c] Drew Adams
2014-01-25 10:00 ` Jarek Czekalski
2014-01-24 16:43 ` Patches with independent changes Paul Eggert
2014-01-24 21:39 ` Eli Zaretskii
2014-01-24 22:34 ` Paul Eggert
2014-01-25 7:22 ` Eli Zaretskii
2014-01-25 17:01 ` Paul Eggert
2014-01-25 17:22 ` Eli Zaretskii
2014-01-25 17:25 ` Eli Zaretskii
2014-01-25 20:58 ` Paul Eggert
2014-01-26 3:47 ` Eli Zaretskii
2014-01-26 7:41 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lhy5ests.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.