From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17146: 24.4.50; File save with incapable coding system precluded by strange error message Date: Mon, 31 Mar 2014 18:16:00 +0300 Message-ID: <83lhvqcsb3.fsf@gnu.org> References: <87ha6fyw1e.fsf@nbtrap.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1396279013 18372 80.91.229.3 (31 Mar 2014 15:16:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 31 Mar 2014 15:16:53 +0000 (UTC) Cc: 17146@debbugs.gnu.org To: Nathan Trapuzzano Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 31 17:16:47 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WUdx8-0005Ka-JA for geb-bug-gnu-emacs@m.gmane.org; Mon, 31 Mar 2014 17:16:46 +0200 Original-Received: from localhost ([::1]:49358 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUdx8-0002Oz-6E for geb-bug-gnu-emacs@m.gmane.org; Mon, 31 Mar 2014 11:16:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUdwY-0001f3-9l for bug-gnu-emacs@gnu.org; Mon, 31 Mar 2014 11:16:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WUdwR-00061C-CP for bug-gnu-emacs@gnu.org; Mon, 31 Mar 2014 11:16:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUdwR-000613-8h for bug-gnu-emacs@gnu.org; Mon, 31 Mar 2014 11:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WUdwQ-0005rV-Ek for bug-gnu-emacs@gnu.org; Mon, 31 Mar 2014 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Mar 2014 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17146 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17146-submit@debbugs.gnu.org id=B17146.139627896122524 (code B ref 17146); Mon, 31 Mar 2014 15:16:02 +0000 Original-Received: (at 17146) by debbugs.gnu.org; 31 Mar 2014 15:16:01 +0000 Original-Received: from localhost ([127.0.0.1]:58007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WUdwO-0005rB-7k for submit@debbugs.gnu.org; Mon, 31 Mar 2014 11:16:00 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:41683) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WUdwK-0005qx-Pm for 17146@debbugs.gnu.org; Mon, 31 Mar 2014 11:15:58 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N3B000003M27500@a-mtaout20.012.net.il> for 17146@debbugs.gnu.org; Mon, 31 Mar 2014 18:15:54 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3B00NK73QI3250@a-mtaout20.012.net.il>; Mon, 31 Mar 2014 18:15:54 +0300 (IDT) In-reply-to: <87ha6fyw1e.fsf@nbtrap.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87570 Archived-At: > From: Nathan Trapuzzano > Date: Sun, 30 Mar 2014 21:52:13 -0400 > > On trunk: > > emacs -nw -q file.txt > M-: (insert "μ\xc1") > C-x C-s > > This throws a "make-text-button" error "Unknown button type > `help-xref'". And it doesn't save. I believe it should ask which > coding system I want to use to write to disk. (The -nw part is not needed to reproduce the problem.) This is because of this commit: ------------------------------------------------------------ revno: 116839 fixes bug: http://debbugs.gnu.org/16038 committer: Leo Liu branch nick: trunk timestamp: Sat 2014-03-22 08:13:46 +0000 message: * help.el (temp-buffer-setup-hook): Remove help-mode-setup. (temp-buffer-show-hook): Remove help-mode-finish. This change is backward-incompatible, but is not in NEWS for some reason. Needless to say, the canonical way of fixing the fallout is not described in NEWS. Are functions that need Help mode supposed to let-bind these hooks? If so, the patch below should fix the problem. In any case, please document the change and the way to adapt to it in NEWS. --- lisp/international/mule-cmds.el~ 2014-01-01 10:46:07 +0200 +++ lisp/international/mule-cmds.el 2014-03-31 08:53:35 +0300 @@ -703,6 +703,8 @@ (let ((window-configuration (current-window-configuration)) (bufname (buffer-name)) + (temp-buffer-setup-hook 'help-mode-setup) + (temp-buffer-show-hook 'help-mode-finish) coding-system) (save-excursion ;; If some defaults are unsafe, make sure the offending