all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Nathan Trapuzzano <nbtrap@nbtrap.com>
Cc: 17146@debbugs.gnu.org
Subject: bug#17146: 24.4.50; File save with incapable coding system precluded by strange error	message
Date: Mon, 31 Mar 2014 18:16:00 +0300	[thread overview]
Message-ID: <83lhvqcsb3.fsf@gnu.org> (raw)
In-Reply-To: <87ha6fyw1e.fsf@nbtrap.com>

> From: Nathan Trapuzzano <nbtrap@nbtrap.com>
> Date: Sun, 30 Mar 2014 21:52:13 -0400
> 
> On trunk:
> 
> emacs -nw -q file.txt
> M-: (insert "μ\xc1")
> C-x C-s
> 
> This throws a "make-text-button" error "Unknown button type
> `help-xref'".  And it doesn't save.  I believe it should ask which
> coding system I want to use to write to disk.

(The -nw part is not needed to reproduce the problem.)

This is because of this commit:

  ------------------------------------------------------------
  revno: 116839
  fixes bug: http://debbugs.gnu.org/16038
  committer: Leo Liu <sdl.web@gmail.com>
  branch nick: trunk
  timestamp: Sat 2014-03-22 08:13:46 +0000
  message:
    * help.el (temp-buffer-setup-hook): Remove help-mode-setup.
    (temp-buffer-show-hook): Remove help-mode-finish.

This change is backward-incompatible, but is not in NEWS for some
reason.  Needless to say, the canonical way of fixing the fallout is
not described in NEWS.  Are functions that need Help mode supposed to
let-bind these hooks?  If so, the patch below should fix the problem.
In any case, please document the change and the way to adapt to it in
NEWS.

--- lisp/international/mule-cmds.el~	2014-01-01 10:46:07 +0200
+++ lisp/international/mule-cmds.el	2014-03-31 08:53:35 +0300
@@ -703,6 +703,8 @@
 
   (let ((window-configuration (current-window-configuration))
 	(bufname (buffer-name))
+	(temp-buffer-setup-hook 'help-mode-setup)
+	(temp-buffer-show-hook 'help-mode-finish)
 	coding-system)
     (save-excursion
       ;; If some defaults are unsafe, make sure the offending





  reply	other threads:[~2014-03-31 15:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31  1:52 bug#17146: 24.4.50; File save with incapable coding system precluded by strange error message Nathan Trapuzzano
2014-03-31 15:16 ` Eli Zaretskii [this message]
2014-03-31 15:30   ` Drew Adams
2014-03-31 15:54     ` Eli Zaretskii
     [not found] <<87ha6fyw1e.fsf@nbtrap.com>
     [not found] ` <<83lhvqcsb3.fsf@gnu.org>
     [not found]   ` <<aa071e4a-793d-4035-9d7e-04c07955b130@default>
     [not found]     ` <<83ha6ecqj3.fsf@gnu.org>
2014-05-05  2:01       ` Drew Adams
2014-05-05  6:20         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lhvqcsb3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=17146@debbugs.gnu.org \
    --cc=nbtrap@nbtrap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.