From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree Date: Wed, 19 Nov 2014 22:32:06 +0200 Message-ID: <83lhn76iex.fsf@gnu.org> References: <87lhn7s522.fsf@rosalinde.fritz.box> <83lhn789tq.fsf@gnu.org> <87h9xvruan.fsf@rosalinde.fritz.box> <83tx1v6mur.fsf@gnu.org> <87a93nrlql.fsf@rosalinde.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1416429205 6399 80.91.229.3 (19 Nov 2014 20:33:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Nov 2014 20:33:25 +0000 (UTC) Cc: paul@tilk.co, 19102@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 19 21:33:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrBwD-0006YR-PL for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 21:33:17 +0100 Original-Received: from localhost ([::1]:60571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrBwD-00054N-D0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 15:33:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrBw4-00052j-Qm for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 15:33:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrBvy-0001Tq-N2 for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 15:33:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrBvy-0001Tl-Kl for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 15:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XrBvy-00045m-Da for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 15:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Nov 2014 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19102 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19102-submit@debbugs.gnu.org id=B19102.141642913415664 (code B ref 19102); Wed, 19 Nov 2014 20:33:02 +0000 Original-Received: (at 19102) by debbugs.gnu.org; 19 Nov 2014 20:32:14 +0000 Original-Received: from localhost ([127.0.0.1]:38709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrBvC-00044a-Ee for submit@debbugs.gnu.org; Wed, 19 Nov 2014 15:32:14 -0500 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:41985) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrBv9-00044P-4b for 19102@debbugs.gnu.org; Wed, 19 Nov 2014 15:32:12 -0500 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NFA00500YVUJV00@mtaout24.012.net.il> for 19102@debbugs.gnu.org; Wed, 19 Nov 2014 22:24:32 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NFA00PGFZCW7H60@mtaout24.012.net.il>; Wed, 19 Nov 2014 22:24:32 +0200 (IST) In-reply-to: <87a93nrlql.fsf@rosalinde.fritz.box> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96279 > From: Stephen Berman > Cc: paul@tilk.co, 19102@debbugs.gnu.org > Date: Wed, 19 Nov 2014 21:14:42 +0100 > > > Wouldn't using eolp instead of the comparison solve that problem more > > easily? > > Well, that eliminates the wrong-type-argument error in the current code, > but it instead signals "End of buffer" >From forward-char? If so, you could avoid the call if eobp. Or wrap the call in condition-case and ignore errors. > Do you see any other problems with the patch or more room for > improvement? I was worried by the complexity of maybe-forward-char, but maybe now it is much simpler.