From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20629: 25.0.50; Regression: TAGS broken, can't find anything in C++ files. Date: Mon, 25 May 2015 18:15:33 +0300 Message-ID: <83lhgczo16.fsf@gnu.org> References: <555EC552.5010600@swipnet.se> <55606A8F.1020109@swipnet.se> <55606CC7.3010401@yandex.ru> <55606F70.10605@swipnet.se> <83twv31jzg.fsf@gnu.org> <83pp5r1hdx.fsf@gnu.org> <83mw0v1e5n.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1432567045 11664 80.91.229.3 (25 May 2015 15:17:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 May 2015 15:17:25 +0000 (UTC) Cc: 20629@debbugs.gnu.org To: jan.h.d@swipnet.se Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 25 17:17:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ywu7t-0000Kf-CE for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 May 2015 17:17:13 +0200 Original-Received: from localhost ([::1]:44040 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ywu7s-00025E-HC for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 May 2015 11:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ywu7m-000257-AZ for bug-gnu-emacs@gnu.org; Mon, 25 May 2015 11:17:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ywu7i-0007RI-Ds for bug-gnu-emacs@gnu.org; Mon, 25 May 2015 11:17:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ywu7i-0007RE-Ap for bug-gnu-emacs@gnu.org; Mon, 25 May 2015 11:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ywu7h-000144-Od for bug-gnu-emacs@gnu.org; Mon, 25 May 2015 11:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 May 2015 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20629 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20629-submit@debbugs.gnu.org id=B20629.14325669644019 (code B ref 20629); Mon, 25 May 2015 15:17:01 +0000 Original-Received: (at 20629) by debbugs.gnu.org; 25 May 2015 15:16:04 +0000 Original-Received: from localhost ([127.0.0.1]:55746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ywu6i-00012J-Bs for submit@debbugs.gnu.org; Mon, 25 May 2015 11:16:04 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:33603) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ywu6b-00011z-Sb for 20629@debbugs.gnu.org; Mon, 25 May 2015 11:15:58 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NOW00K00VMJF000@a-mtaout23.012.net.il> for 20629@debbugs.gnu.org; Mon, 25 May 2015 18:15:46 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NOW00KV6VQABV50@a-mtaout23.012.net.il>; Mon, 25 May 2015 18:15:46 +0300 (IDT) In-reply-to: <83mw0v1e5n.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103156 Archived-At: > Date: Sat, 23 May 2015 18:56:04 +0300 > From: Eli Zaretskii > Cc: 20629@debbugs.gnu.org > > > Does the patch below give good results in real-life C++ usage? > > > > Please also consider whether this change could cause trouble in other > > C++ use cases. (I've ran the modified version on the etags test > > suite, and didn't spot any problems in the differences with the > > previous results, but I don't consider myself an expert on C++ > > syntax.) > > I see that etags deliberately produces explicitly named tags of the > form CLASS::MEMBER, whenever it sees a declaration of MEMBER inside a > class declaration of CLASS. Why is that useful? It is another > instance that defeats the change which removed tag-symbol-match-p from > the "order" functions used by etags.el when invoked from xref. Does > anyone see a problem with removing this feature from etags? I've attempted to fix this and other underlying problems by suitable changes in etags.c in commit 9c66c5a. The feature whereby etags qualifies class members by their class names in TAGS is now optional, off by default, which creates tag names that are more accurate, and xref should now work much better with C-like object-oriented languages. Please give it a try, including in real-life use cases. I'm not yet closing the bug on account of possible complications. Thanks.