Re: Please add comments to isearch.el

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 11 Dec 2015 16:00:27 +0000
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: Alan Mackenzie <acm@muc.de>, emacs-devel <emacs-devel@gnu.org>
> 
> 2015-12-11 12:39 GMT+00:00 Eli Zaretskii <eliz@gnu.org>:
> > For example, start with isearch-mode, and then try to figure out what
> > each one of the following variables are in what use cases:
> > regexp-function and search-default-regexp-mode (as a function).  You
> > will see that each one can be assigned to a variable that names a
> > function that has a default value that can be a function that...
> 
> I didn't reply to your initial message for lack of time. I can add
> some comments here and there on the parts I understand. (some time in
> the coming months)

Thanks in advance.

> > Similarly with other isearch commands.  This makes the source
> > impenetrable to uninitiated, much harder than just stepping with
> > Edebug through the code.  IMO, if it is easier to understand code by
> > stepping through it in a debugger than by reading it, that code must
> > be refactored or documented the heck of.
> 
> Honestly, I'd love to overhaul isearch. But I couldn't do it
> backwards-compatibly.

That's what master is for.