From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 f8208b6: Document the user-level features of the Xref package Date: Fri, 22 Jan 2016 10:21:24 +0200 Message-ID: <83lh7i6n3v.fsf@gnu.org> References: <20160109191428.26341.44105@vcs.savannah.gnu.org> <5691C9D2.7080905@yandex.ru> <83egdpmo1j.fsf@gnu.org> <56929D6F.2050508@yandex.ru> <834melmfa4.fsf@gnu.org> <5692B1E0.8010100@yandex.ru> <831t9pma4e.fsf@gnu.org> <5693FDFA.2070607@yandex.ru> <83ziwbkj5l.fsf@gnu.org> <5694055E.6050201@yandex.ru> <83si1udcaz.fsf@gnu.org> <569D64AC.1060606@yandex.ru> <83powxbh6c.fsf@gnu.org> <569EB04F.800@yandex.ru> <8337tsc133.fsf@gnu.org> <56A05073.5090100@yandex.ru> <83powu96yo.fsf@gnu.org> <86egda68q6.fsf@stephe-leake.org> <56A130FA.4040306@yandex.ru> <86bn8e3vvv.fsf@stephe-leake.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1453450898 24416 80.91.229.3 (22 Jan 2016 08:21:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Jan 2016 08:21:38 +0000 (UTC) Cc: emacs-devel@gnu.org, dgutov@yandex.ru To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 22 09:21:34 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aMWyK-0007k9-EK for ged-emacs-devel@m.gmane.org; Fri, 22 Jan 2016 09:21:32 +0100 Original-Received: from localhost ([::1]:51246 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMWyE-0006BI-TD for ged-emacs-devel@m.gmane.org; Fri, 22 Jan 2016 03:21:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMWxz-0006BC-93 for emacs-devel@gnu.org; Fri, 22 Jan 2016 03:21:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMWxw-0007i8-33 for emacs-devel@gnu.org; Fri, 22 Jan 2016 03:21:11 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMWxv-0007hy-VU; Fri, 22 Jan 2016 03:21:08 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4933 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aMWxv-0003eI-94; Fri, 22 Jan 2016 03:21:07 -0500 In-reply-to: <86bn8e3vvv.fsf@stephe-leake.org> (message from Stephen Leake on Fri, 22 Jan 2016 01:40:04 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198563 Archived-At: > From: Stephen Leake > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Fri, 22 Jan 2016 01:40:04 -0600 > > Dmitry Gutov writes: > > > On 01/21/2016 10:19 PM, Stephen Leake wrote: > > > >> xref-find-apropos > >> > >> This is just a search, not relying on any "cross reference" > >> information. > >> > >> project-find-* provides the same functionality, so xref-find-apropos > >> can be removed (assuming every xref backend provides a project > >> backend). > > > > No, "apropos" lists the *definitions* matching a regexp. You won't get > > that by simply using regexp-search. > > The doc string says: > > Find all meaningful symbols that match PATTERN. > The argument has the same meaning as in ‘apropos’. The doc string "needs work"™. Welcome to the issue of doc strings of quite a few commands introduced in Emacs 25. Feel free to augment, expand, improve, or even rewrite any of them, based on what the code actually does. Thanks in advance. > I read that as "all occurances of the regexp"; I don't know what > "meaningful" is supposed to mean here. > > If it is supposed to find only definitions, the doc string should say > so: > > Find the definitions of all symbols that match PATTERN. > PATTERN has the same meaning as in `apropos'. The manual says: The command `C-M-.' (`xref-find-apropos') finds the definitions of one or more identifiers that match a specified regular expression. It is just like `M-.' except that it does regexp matching of identifiers instead of matching symbol names as fixed strings. > However, the etags implementation uses re-search-forward to find PATTERN > in the tags files; that won't handle word lists as `apropos' does. So > does that need to be fixed, or should we change the doc string further > to say: > > Find the definitions of all symbols that match PATTERN (a regexp). Good question.