From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 23219@debbugs.gnu.org
Subject: bug#23219: 25.0.92; Find command cannot be customized for grep-find
Date: Tue, 05 Apr 2016 18:40:15 +0300 [thread overview]
Message-ID: <83lh4sm5cw.fsf@gnu.org> (raw)
In-Reply-To: <dbc78257-4779-6909-99b9-308bccfea777@yandex.ru> (message from Dmitry Gutov on Tue, 5 Apr 2016 18:12:46 +0300)
> Cc: 23219@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Tue, 5 Apr 2016 18:12:46 +0300
>
> On 04/05/2016 06:01 PM, Eli Zaretskii wrote:
>
> > -(defvar grep-program (purecopy "grep")
> > +(defcustom grep-grep-program (purecopy "grep")
>
> I didn't mean to suggest renaming the variables.
I don't think it's a good idea to have, say, 'find-program' in grep.el
without a prefix.
> At the very least, we'd need obsolete aliases, as they're likely to
> be used in some third party code.
Right, will do.
> Also, grep-grep-program looks weird.
I can make it grep-program again.
> > "The default grep program for `grep-command' and `grep-find-command'.
> > -This variable's value takes effect when `grep-compute-defaults' is called.")
> > +This variable's value takes effect when `grep-compute-defaults' is called."
> > + :type 'string
> > + :set 'grep-apply-setting
>
> Does grep-apply-setting expect the new variables? Its docstring disagrees.
I will double-check.
Thanks.
next prev parent reply other threads:[~2016-04-05 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 20:37 bug#23219: 25.0.92; Find command cannot be customized for grep-find Eli Zaretskii
2016-04-04 21:16 ` Dmitry Gutov
2016-04-05 15:01 ` Eli Zaretskii
2016-04-05 15:12 ` Dmitry Gutov
2016-04-05 15:40 ` Eli Zaretskii [this message]
2016-04-05 15:42 ` Dmitry Gutov
2016-04-08 13:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lh4sm5cw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23219@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.