From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Redisplay: NS port, high CPU load Date: Fri, 10 Jun 2016 12:34:40 +0300 Message-ID: <83lh2dpetr.fsf@gnu.org> References: <9793F9E3-979A-4888-8662-F6E0C27C8B37@gmail.com> <20160608195552.GA66865@breton.holly.idiocy.org> <7B0CAF99-689D-4128-8E33-7D9BA8F1823E@gmail.com> <41E503B6-5048-4E20-92CE-1FAD4C05A279@gmail.com> <525668A8-4B0E-4791-A423-F1D4903F4511@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1465551286 13163 80.91.229.3 (10 Jun 2016 09:34:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Jun 2016 09:34:46 +0000 (UTC) Cc: alan@idiocy.org, andlind@gmail.com, emacs-devel@gnu.org To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 10 11:34:41 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bBIps-0005QJ-C1 for ged-emacs-devel@m.gmane.org; Fri, 10 Jun 2016 11:34:40 +0200 Original-Received: from localhost ([::1]:39326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBIpr-00054k-ED for ged-emacs-devel@m.gmane.org; Fri, 10 Jun 2016 05:34:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBIpH-00053o-Nx for emacs-devel@gnu.org; Fri, 10 Jun 2016 05:34:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBIpE-0000jA-G7 for emacs-devel@gnu.org; Fri, 10 Jun 2016 05:34:03 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBIpE-0000j2-CV; Fri, 10 Jun 2016 05:34:00 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4431 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bBIpC-0001jH-3N; Fri, 10 Jun 2016 05:33:58 -0400 In-reply-to: <525668A8-4B0E-4791-A423-F1D4903F4511@gmail.com> (message from David Reitter on Fri, 10 Jun 2016 18:16:39 +1000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204268 Archived-At: > From: David Reitter > Date: Fri, 10 Jun 2016 18:16:39 +1000 > Cc: Alan Third , > Emacs-Devel devel > > On Jun 10, 2016, at 4:02 PM, Anders Lindgren wrote: > > > I will be away for the weekend, so if you have write access, feel free to commit it yourself. Otherwise, I can do it at the beginning of next week. Personally, I think this should go into the emacs-25 branch but we will have to get that approved from John or Eli. > > Good, I have checked in the change. > > Eli, this addresses a high-CPU-load condition on OS X when a revert-buffer icon is present in the toolbar and the current buffer was unmodified. This may or may not be the somewhat difficult-to-trace 100% CPU load bug a lot of us have been seeing on OSX. The functionality of the utf-8-hfs coding system for the filesystem is preserved is tests. > > I would suggest to merge this into emacs-25. If you want it on the release branch, why did you push it to master? This just makes things more complicated than they should be. > Also, I would suggest to check whether code like this should indeed trigger an update_frame_tool_bar. > > (with-temp-buffer > (insert "XXX")) I don't think so. It doesn't here. How did you check that it does on your system?