Re: Redisplay: NS port, high CPU load

[Eli Zaretskii <eliz@gnu.org>]

> From: David Reitter <david.reitter@gmail.com>
> Date: Fri, 10 Jun 2016 18:16:39 +1000
> Cc: Alan Third <alan@idiocy.org>,
>  Emacs-Devel devel <emacs-devel@gnu.org>
> 
> On Jun 10, 2016, at 4:02 PM, Anders Lindgren <andlind@gmail.com> wrote:
> 
> > I will be away for the weekend, so if you have write access, feel free to commit it yourself. Otherwise, I can do it at the beginning of next week. Personally, I think this should go into the emacs-25 branch but we will have to get that approved from John or Eli.
> 
> Good, I have checked in the change.
> 
> Eli, this addresses a high-CPU-load condition on OS X when a revert-buffer icon is present in the toolbar and the current buffer was unmodified.  This may or may not be the somewhat difficult-to-trace 100% CPU load bug a lot of us have been seeing on OSX.   The functionality of the utf-8-hfs coding system for the filesystem is preserved is tests.
> 
> I would suggest to merge this into emacs-25.

If you want it on the release branch, why did you push it to master?
This just makes things more complicated than they should be.

> Also, I would suggest to check whether code like this should indeed trigger an update_frame_tool_bar.
> 
>   (with-temp-buffer
>    (insert "XXX"))

I don't think so.  It doesn't here.  How did you check that it does on
your system?