From: Eli Zaretskii <eliz@gnu.org>
To: rswgnu@gmail.com
Cc: 23794@debbugs.gnu.org, rms@gnu.org, emacs-devel@gnu.org
Subject: bug#23794: Emacs bug #23794; sort-line behavior regressed from prior Emacs versions
Date: Sun, 19 Jun 2016 19:55:14 +0300 [thread overview]
Message-ID: <83lh2186fh.fsf__33123.1218217455$1466355427$gmane$org@gnu.org> (raw)
In-Reply-To: <CA+OMD9jOBhas2Bt-7rc92UdLuPxWhJj2mEAc2KLgWAVdGFaOvw@mail.gmail.com> (message from Robert Weiner on Sun, 19 Jun 2016 12:51:08 -0400)
> From: Robert Weiner <rsw@gnu.org>
> Date: Sun, 19 Jun 2016 12:51:08 -0400
> Cc: Drew Adams <drew.adams@oracle.com>, Richard Stallman <rms@gnu.org>,
> emacs-devel <emacs-devel@gnu.org>, 23794@debbugs.gnu.org
>
> On Sun, Jun 19, 2016 at 12:30 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
> Didn't think that far, but is it really clean for sort-lines to have
> special code for some major mode? I thought a better way is to
> override the default behavior by having sort-lines call functions
> through funcall or somesuch, and then outline modes could set the
> appropriate variable to the function of their liking?
>
> The problem with that approach is that each mode has to be aware of this and add a setting, really not much
> different than each mode having its own sort function or way of calling a sort function. It is much more useful
> to centralize the behavior within the sorting library, even if it adds some conditional complexity to the code.
Not necessarily: if you set that up in outline-mode, all of its
descendants will inherit the setting for free.
> Here is the suggested patch to do it this way. -- Bob
Thanks, I hope others will comment on this.
next prev parent reply other threads:[~2016-06-19 16:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 17:01 Emacs bug #23794; sort-line behavior regressed from prior Emacs versions Robert Weiner
2016-06-18 17:26 ` Eli Zaretskii
2016-06-18 17:42 ` Eli Zaretskii
2016-06-18 17:50 ` Robert Weiner
2016-06-18 18:15 ` Eli Zaretskii
2016-06-18 18:22 ` Stefan Monnier
2016-06-18 18:28 ` Eli Zaretskii
2016-06-18 18:37 ` Robert Weiner
2016-06-18 18:31 ` Robert Weiner
2016-06-18 21:28 ` Drew Adams
2016-06-18 22:41 ` Robert Weiner
2016-06-19 2:39 ` Eli Zaretskii
2016-06-19 13:31 ` Robert Weiner
2016-06-19 15:18 ` Eli Zaretskii
2016-06-19 16:12 ` Robert Weiner
2016-06-19 16:30 ` Eli Zaretskii
2016-06-19 16:51 ` bug#23794: " Robert Weiner
2016-06-19 16:55 ` Eli Zaretskii
2016-06-19 17:03 ` bug#23794: " Robert Weiner
2016-06-19 17:03 ` Robert Weiner
2016-06-19 16:55 ` Eli Zaretskii [this message]
2016-06-19 20:59 ` bug#23794: " Drew Adams
2016-06-19 20:59 ` Drew Adams
2016-06-20 0:55 ` bug#23794: " Stefan Monnier
2016-06-19 18:16 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='83lh2186fh.fsf__33123.1218217455$1466355427$gmane$org@gnu.org' \
--to=eliz@gnu.org \
--cc=23794@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
--cc=rswgnu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.