From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Use specific functions to create shell processes
Date: Thu, 25 Aug 2016 17:35:21 +0300 [thread overview]
Message-ID: <83lgzkex1y.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1608251550350.5579@calancha-pc> (message from Tino Calancha on Thu, 25 Aug 2016 15:52:03 +0900 (JST))
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Thu, 25 Aug 2016 15:52:03 +0900 (JST)
> Cc: tino.calancha@gmail.com
>
> we have in subr.el, specific funtions to create processes
> when the program is a shell, e.g., call-process-shell-command.
> Using these funtions when appropiate, i.e., when the program
> is a shell, results in a more readable code.
> I have noticed that not all the code in the Emacs tree use these
> functions.
>
> I propose a patch to replace calls to general functions creating
> processes with the shell specific ones, when the program is a shell.
>
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> >From c036272adeb7268c0d496e40d6cd4410e9ecac7d Mon Sep 17 00:00:00 2001
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Thu, 25 Aug 2016 15:45:46 +0900
> Subject: [PATCH] Use specific functions to create shell processes
>
> subr.el define specific functions to create processes when
> the program is a shell. Replace calls to the general
> functions creating processes with calls to
> the shell specific if the program is a shell.
> (lisp/calc/calc-graph.el, lisp/gnus/gnus-art.el)
> (lisp/gnus/gnus-dired.el, lisp/gnus/gnus-fun.el)
> (lisp/gnus/gnus-sum.el, lisp/gnus/gnus-uu.el)
> (lisp/gnus/mail-source.el, lisp/gnus/mm-decode.el)
> (lisp/ibuf-ext.el, lisp/image-dired.el)
> (lisp/mail/mailalias.el, lisp/man.el)
> (lisp/mh-e/mh-print.el, lisp/net/network-stream.el)
> (lisp/org/ob-eval.el, lisp/progmodes/ada-xref.el)
> (lisp/progmodes/compile.el, lisp/progmodes/gdb-mi.el)
> (lisp/progmodes/verilog-mode.el, lisp/simple.el)
> (lisp/vc/diff.el):
> Use 'process-file-shell-command', 'call-process-shell-command',
> 'start-process-shell-command', and 'start-file-process-shell-command'
> instead of 'process-file', 'call-process', 'start-process'
> and 'start-file-process' if the program is a shell.
Thanks for working on this.
Like I said in the past, I'd like us to have a test for each
functionality whose implementation we are refactoring. Can we do that
in this case?
next prev parent reply other threads:[~2016-08-25 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 6:52 Use specific functions to create shell processes Tino Calancha
2016-08-25 14:35 ` Eli Zaretskii [this message]
2016-08-26 10:25 ` Tino Calancha
2016-08-26 10:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lgzkex1y.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.