From: Eli Zaretskii <eliz@gnu.org>
To: "Dr. Werner Fink" <werner@suse.de>
Cc: 25228@debbugs.gnu.org
Subject: bug#25228: [emacs-bug] bug#25228: 25.1; GNU emacs 25.1: custom-set-faces from init file ~/.emacs ignored
Date: Tue, 20 Dec 2016 19:58:18 +0200 [thread overview]
Message-ID: <83lgva32kl.fsf@gnu.org> (raw)
In-Reply-To: <20161220165648.6iovnl7d4gh3g7qz@boole.suse.de> (werner@suse.de)
> Date: Tue, 20 Dec 2016 17:56:48 +0100
> From: "Dr. Werner Fink" <werner@suse.de>
> Cc: Eli Zaretskii <eliz@gnu.org>, 25228@debbugs.gnu.org
>
> > The only guess I have is that the correction had now enabled the :user-spec
> > key/attribute. For a workaround I've change some lines of code in
> > lisp/dynamic-setting.el ... compare with the attached patch.
> >
> > With this patch both the custom font if enabled in ~/.emacs as well as
> > the system font works here for GNU Emacs with GTK as well as with X11.
>
> Wrong version of the patch, this one seems to be better one ;)
Thanks. However, this doesn't look like the right fix, because this:
> + (let ((system-font (and (fboundp 'font-get-system-font)
> + (font-get-system-font)))
> + (frame-list (frames-on-display-list display-or-frame))
> + (user-font (face-attribute 'default :font)))
> + (when (and system-font (display-graphic-p display-or-frame))
> (clear-font-cache)
> (if set-font
> ;; Set the font on all current and future frames, as though
> ;; the `default' face had been "set for this session":
> - (set-frame-font new-font nil frame-list)
> + (if (not user-font)
> + (set-frame-font system-font nil frame-list)
> + (set-frame-font user-font nil frame-list))
effectively disables the system-font feature, because
(face-attribute 'default :font)
will always return non-nil.
So if my suggestion of rounding the DPI values before comparing them
fixes this for you, it sounds like a better solution to me.
prev parent reply other threads:[~2016-12-20 17:58 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 10:03 bug#25228: 25.1; GNU emacs 25.1: custom-set-faces from init file ~/.emacs ignored Dr. Werner Fink
2016-12-19 15:09 ` bug#25228: [emacs-bug] " Dr. Werner Fink
2016-12-19 17:37 ` Eli Zaretskii
2016-12-19 18:36 ` martin rudalics
2016-12-19 18:57 ` Eli Zaretskii
2016-12-19 20:20 ` martin rudalics
2016-12-19 20:43 ` Eli Zaretskii
2016-12-20 10:59 ` martin rudalics
2016-12-20 16:11 ` Eli Zaretskii
2016-12-20 16:25 ` martin rudalics
2016-12-20 17:06 ` Eli Zaretskii
2016-12-20 17:28 ` Dr. Werner Fink
2016-12-20 17:34 ` martin rudalics
2016-12-20 17:55 ` Eli Zaretskii
2016-12-20 18:18 ` martin rudalics
2016-12-20 18:39 ` Eli Zaretskii
2016-12-20 18:49 ` martin rudalics
2016-12-20 19:31 ` Eli Zaretskii
2016-12-20 19:11 ` Rostislav Svoboda
2016-12-20 19:24 ` Rostislav Svoboda
2016-12-20 19:34 ` Eli Zaretskii
2016-12-20 21:50 ` Rostislav Svoboda
2016-12-21 7:42 ` martin rudalics
2016-12-21 11:03 ` Rostislav Svoboda
2016-12-21 17:25 ` Eli Zaretskii
2016-12-22 8:35 ` martin rudalics
2016-12-22 11:59 ` Rostislav Svoboda
2016-12-22 17:45 ` martin rudalics
2016-12-20 19:29 ` martin rudalics
2016-12-21 8:11 ` Dr. Werner Fink
2016-12-21 8:47 ` bug#25228: [emacs-bug] " Dr. Werner Fink
2016-12-21 8:56 ` martin rudalics
2016-12-21 11:08 ` Dr. Werner Fink
2016-12-22 8:35 ` martin rudalics
2016-12-22 11:46 ` Dr. Werner Fink
2016-12-22 17:44 ` martin rudalics
2016-12-23 7:20 ` Dr. Werner Fink
2016-12-21 17:24 ` Eli Zaretskii
2016-12-21 17:39 ` Dr. Werner Fink
2016-12-21 18:04 ` Eli Zaretskii
2016-12-21 8:48 ` martin rudalics
2016-12-21 12:08 ` Dr. Werner Fink
2016-12-21 17:34 ` Eli Zaretskii
2016-12-22 8:35 ` martin rudalics
2016-12-22 17:30 ` Eli Zaretskii
2016-12-22 17:45 ` martin rudalics
2016-12-23 7:29 ` Dr. Werner Fink
2016-12-20 11:18 ` Dr. Werner Fink
2016-12-20 16:15 ` Eli Zaretskii
2016-12-20 16:41 ` Dr. Werner Fink
2016-12-20 16:56 ` bug#25228: [emacs-bug] " Dr. Werner Fink
2016-12-20 17:58 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lgva32kl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25228@debbugs.gnu.org \
--cc=werner@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.