From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: hariharanrangasamy@gmail.com, 26710@debbugs.gnu.org
Subject: bug#26710: Fwd: 25.2; project-find-regexp makes emacs use 100% cpu
Date: Tue, 02 May 2017 10:15:15 +0300 [thread overview]
Message-ID: <83lgqfivb0.fsf@gnu.org> (raw)
In-Reply-To: <b283056e-7b17-86c2-7d59-1f9015146130@yandex.ru> (message from Dmitry Gutov on Tue, 2 May 2017 00:46:25 +0300)
> Cc: hariharanrangasamy@gmail.com, 26710@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Tue, 2 May 2017 00:46:25 +0300
>
> See commit c99a3b9. Please take a look at
> xref--regexp-syntax-dependent-p specifically, and see if any significant
> false negatives come to mind.
Can you explain the significance of xref--regexp-syntax-dependent-p's
tests? I don't know enough about xref to grasp that just by looking
at the changes.
> With this, project-find-regexp for 'emacs' finally completes in ~10
> seconds on my machine.
It takes about 15 here (and 45 in an unoptimized build). I guess this
slowdown is expected, since this is a 32-bit build --with-wide-int, so
should be 30% slower than with native ints.
I don't remember the original timings, but this looks like a good
improvement, thanks.
> >> What we _can_ manage to run in parallel, in the find-grep process in the
> >> background, and the post-processing of the results in Elisp.
> >
> > Yes, you can -- if you invoke find-grep asynchronously and move the
> > processing of the hits to the filter function.
>
> Yes, these parts are necessary either way. What I was describing would
> go on top of them, as an abstraction.
If the processing is in filter and sentinel functions, I'm not sure we
will need any further speedups, because the UI will remain responsive.
> > But that doesn't need
> > to involve threads, and is being done in many packages/features out
> > there, so I'm not sure what did you ask me to do with this.
>
> I imagined that the xref API that allows this kind of asynchronous
> results might look better and more readable if it's implemented with
> threads underneath.
If you need advice for how to implement something like that, I can try
helping with threads.
> The main thing to understand is the xref API, not the internals of the
> package.
Well, I lack that understanding as well.
next prev parent reply other threads:[~2017-05-02 7:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87a86zu3gf.fsf@hari-laptop.i-did-not-set--mail-host-address--so-tickle-me>
2017-04-29 8:55 ` bug#26710: Fwd: 25.2; project-find-regexp makes emacs use 100% cpu Hariharan Rangasamy
2017-04-29 17:00 ` Dmitry Gutov
2017-04-29 17:37 ` Eli Zaretskii
2017-04-30 4:13 ` Hariharan Rangasamy
2017-04-30 10:35 ` Dmitry Gutov
2017-04-30 18:47 ` Eli Zaretskii
2017-05-01 2:42 ` Dmitry Gutov
2017-05-01 7:20 ` Eli Zaretskii
2017-05-01 21:46 ` Dmitry Gutov
2017-05-02 7:15 ` Eli Zaretskii [this message]
2017-05-02 10:00 ` Dmitry Gutov
2017-05-02 17:26 ` Eli Zaretskii
2017-05-02 17:41 ` Eli Zaretskii
2017-05-03 0:14 ` Dmitry Gutov
2017-05-03 2:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lgqfivb0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=26710@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=hariharanrangasamy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.