From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix use of sockaddr_in Date: Wed, 17 May 2017 18:16:23 +0300 Message-ID: <83lgpv5xa0.fsf@gnu.org> References: <83shk989r5.fsf@gnu.org> <20170513150837.31184-1-phst@google.com> <83h90o8zt9.fsf@gnu.org> <877f1kefhi.fsf@linux-m68k.org> <83a86g8siw.fsf@gnu.org> <87y3u0cyjy.fsf@linux-m68k.org> <838tm088yj.fsf@gnu.org> <8337c78qq6.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1495034250 17183 195.159.176.226 (17 May 2017 15:17:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 17 May 2017 15:17:30 +0000 (UTC) Cc: phst@google.com, p.stephani2@gmail.com, schwab@linux-m68k.org, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 17 17:17:23 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dB0hW-0004Ft-8A for ged-emacs-devel@m.gmane.org; Wed, 17 May 2017 17:17:22 +0200 Original-Received: from localhost ([::1]:49481 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dB0hb-0001ou-NW for ged-emacs-devel@m.gmane.org; Wed, 17 May 2017 11:17:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dB0go-0001oc-IM for emacs-devel@gnu.org; Wed, 17 May 2017 11:16:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dB0gk-0004k7-IM for emacs-devel@gnu.org; Wed, 17 May 2017 11:16:38 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dB0gk-0004jz-EP; Wed, 17 May 2017 11:16:34 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3742 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dB0gj-00018O-Ju; Wed, 17 May 2017 11:16:34 -0400 In-reply-to: (message from Paul Eggert on Sun, 14 May 2017 23:15:46 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214911 Archived-At: > Cc: phst@google.com, p.stephani2@gmail.com, emacs-devel@gnu.org > From: Paul Eggert > Date: Sun, 14 May 2017 23:15:46 -0700 > > Eli Zaretskii wrote: > > if your > > intent was to say that this condition should be added to the code, > > i.e. for AF_UNIX we should not try to compute the port, then I agree. > > I installed a modified version of Philipp's patch, to do that. Thanks, Philipp, > for tracking this down. I wonder why you ignored what I said here: http://lists.gnu.org/archive/html/emacs-devel/2017-05/msg00361.html If you disagree, I'd expect you to say so and try to convince, not to go ahead and commit the code.