all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 27843@debbugs.gnu.org
Subject: bug#27843: 26.0.50; Dired w/ eshell insert subdirs content when dir-or-list is a cons
Date: Sat, 29 Jul 2017 12:04:17 +0300	[thread overview]
Message-ID: <83lgn7397y.fsf@gnu.org> (raw)
In-Reply-To: <87bmo6sh1v.fsf@calancha-pc> (message from Tino Calancha on Thu,  27 Jul 2017 12:19:08 +0900)

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Thu, 27 Jul 2017 12:19:08 +0900
> 
> emacs -r -Q -l ls-lisp -eval "(setq ls-lisp-use-insert-directory-program t)"
> ;; Following form must lists just 2 entries in Dired:
> M-: (dired (list source-directory "README" "lisp")) RET
> 
> ;; In fact, it inserts the full content of subdir "lisp".
> 
> --8<-----------------------------cut here---------------start------------->8---
> commit 6216ea9470feabf22333988f02203334fcfd2e26
> Author: Tino Calancha <tino.calancha@gmail.com>
> Date:   Thu Jul 27 12:09:00 2017 +0900
> 
>     Dired w/ eshell: Don't insert subdirs content if dir-or-list is a cons
>     
>     * lisp/eshell/em-ls.el (eshell-ls--insert-directory):
>     Append '("-d") into 'eshell-ls-dired-initial-args'
>     when 'dired-directory' is a cons (Bug#27843).
>     * test/lisp/dired-tests.el (dired-test-bug27843): Add test.

This LGTM, but please rephrase the log summary line to be positive,
not negative.

Thanks.





  parent reply	other threads:[~2017-07-29  9:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27  3:19 bug#27843: 26.0.50; Dired w/ eshell insert subdirs content when dir-or-list is a cons Tino Calancha
2017-07-27  9:26 ` Tino Calancha
2017-07-29  9:07   ` Eli Zaretskii
2017-07-29  9:04 ` Eli Zaretskii [this message]
2017-08-01 14:34   ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lgn7397y.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=27843@debbugs.gnu.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.