From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 28023@debbugs.gnu.org
Subject: bug#28023: fix make-temp-file race on local host
Date: Wed, 09 Aug 2017 22:09:41 +0300 [thread overview]
Message-ID: <83lgmssglm.fsf@gnu.org> (raw)
In-Reply-To: <2ca18723-8d62-11f7-86d8-3e0fc044ac57@cs.ucla.edu> (message from Paul Eggert on Wed, 9 Aug 2017 11:47:36 -0700)
> Cc: 28023@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 9 Aug 2017 11:47:36 -0700
>
> On 08/09/2017 09:05 AM, Eli Zaretskii wrote:
> > We could resolve this problem by providing a way for the Windows build
> > to specify its own replacements for 'open', 'mkdir', and 'lstat'
> > (Emacs already have such replacements in w32.c), which tempname.c
> > calls, but that would require minor changes in Gnulib's tempname.c.
>
> This sounds like a better way to go. What minor changes would be needed?
> tempname.c already includes config.h, which includes ms-w32.h, which
> redefines open, mkdir, and lstat, so I thought it would work as-is.
Perhaps you are right, and it will "just work". I will have to try
(for now, I just looked at the sources and the changes, but didn't try
building).
> > This seems to say that we will sometimes use secure_getenv, but the
> > relevant code in tempname.c is conditioned on _LIBC, which AFAIU is
> > only true when building glibc, so why do we need that? Or did I miss
> > something?
> No, good catch, Emacs never needs secure_getenv. I fixed Gnulib,
> installed the attached patch to propagate that fix, and will adjust the
> proposed make-temp-file patch accordingly.
Thanks.
next prev parent reply other threads:[~2017-08-09 19:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 5:38 bug#28023: fix make-temp-file race on local host Paul Eggert
2017-08-09 6:51 ` Michael Albinus
2017-08-09 9:22 ` Paul Eggert
2017-08-09 11:21 ` Michael Albinus
2017-08-13 7:21 ` Paul Eggert
2017-08-12 10:35 ` Michael Albinus
2017-08-12 15:55 ` Paul Eggert
2017-08-12 16:09 ` Eli Zaretskii
2017-08-12 16:25 ` Paul Eggert
2017-08-12 16:52 ` Eli Zaretskii
2017-08-12 17:57 ` Paul Eggert
2017-08-12 18:07 ` Eli Zaretskii
2017-08-12 17:51 ` Michael Albinus
2017-08-09 16:05 ` Eli Zaretskii
2017-08-09 18:47 ` Paul Eggert
2017-08-09 19:09 ` Eli Zaretskii [this message]
2017-08-09 23:36 ` Paul Eggert
2017-08-10 15:35 ` Eli Zaretskii
2017-08-10 22:24 ` Paul Eggert
2017-08-11 6:21 ` Eli Zaretskii
2017-08-11 7:44 ` Paul Eggert
2017-08-11 8:03 ` Eli Zaretskii
2017-08-12 8:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lgmssglm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28023@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.