From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27986: 26.0.50; 'rename-file' can rename files without confirmation Date: Mon, 14 Aug 2017 20:04:18 +0300 Message-ID: <83lgmmgjxp.fsf@gnu.org> References: <61980dde-3d68-7200-e7f4-98f62e410060@cs.ucla.edu> <0e80a1cf-8217-9e9a-a00f-9fdbd6575fc4@cs.ucla.edu> <83pobygo3d.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1502730328 29039 195.159.176.226 (14 Aug 2017 17:05:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Aug 2017 17:05:28 +0000 (UTC) Cc: eggert@cs.ucla.edu, 27986@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 14 19:05:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhInh-0006qG-3S for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Aug 2017 19:05:13 +0200 Original-Received: from localhost ([::1]:35323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhInn-0000X7-JE for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Aug 2017 13:05:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhIna-0000PD-1j for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 13:05:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhInW-0002rq-Uf for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 13:05:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55495) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhInW-0002rl-RG for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 13:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhInW-0005K0-EN for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 13:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Aug 2017 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27986-submit@debbugs.gnu.org id=B27986.150273027520447 (code B ref 27986); Mon, 14 Aug 2017 17:05:02 +0000 Original-Received: (at 27986) by debbugs.gnu.org; 14 Aug 2017 17:04:35 +0000 Original-Received: from localhost ([127.0.0.1]:35942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhIn4-0005Jj-RT for submit@debbugs.gnu.org; Mon, 14 Aug 2017 13:04:35 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhIn2-0005Jc-SH for 27986@debbugs.gnu.org; Mon, 14 Aug 2017 13:04:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhImu-0002d5-JN for 27986@debbugs.gnu.org; Mon, 14 Aug 2017 13:04:27 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhImu-0002d1-Gr; Mon, 14 Aug 2017 13:04:24 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4798 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dhImu-000354-03; Mon, 14 Aug 2017 13:04:24 -0400 In-reply-to: (message from Philipp Stephani on Mon, 14 Aug 2017 16:58:04 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135752 Archived-At: > From: Philipp Stephani > Date: Mon, 14 Aug 2017 16:58:04 +0000 > Cc: 27986@debbugs.gnu.org > > There's nothing easier than implementing renameat_noreplace on > MS-Windows, since the underlying system call does that by default, and > it's emulating the Posix behavior that requires complications. > > You might be able to eliminate these complications by calling MoveFileExW with > MOVEFILE_REPLACE_EXISTING. Thanks, but I see no need, because using that function doesn't solve any problems we have (it isn't guaranteed to be atomic if the destination exists), and adds new complexity (because it won't move files across volumes, and because it didn't exist before XP). The "complications" I mentioned above are already implemented and well tested, so I see no point in eliminating them.