From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Relics of removed dir-locals-file-2 feature in pretest Date: Wed, 22 Nov 2017 18:20:14 +0200 Message-ID: <83lgiyb801.fsf@gnu.org> References: <833757cqy7.fsf@gnu.org> <83tvxmbat5.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1511367630 1792 195.159.176.226 (22 Nov 2017 16:20:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Nov 2017 16:20:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 22 17:20:26 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHXl7-0008GD-7l for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2017 17:20:21 +0100 Original-Received: from localhost ([::1]:40251 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHXlD-0001zx-0w for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2017 11:20:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHXl7-0001zc-7f for emacs-devel@gnu.org; Wed, 22 Nov 2017 11:20:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHXl2-0004Ob-2o for emacs-devel@gnu.org; Wed, 22 Nov 2017 11:20:21 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHXl1-0004OU-RQ; Wed, 22 Nov 2017 11:20:15 -0500 Original-Received: from [176.228.60.248] (port=4776 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eHXl1-0004PZ-9q; Wed, 22 Nov 2017 11:20:15 -0500 In-reply-to: (message from Kaushal Modi on Wed, 22 Nov 2017 15:58:36 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220360 Archived-At: > From: Kaushal Modi > Date: Wed, 22 Nov 2017 15:58:36 +0000 > Cc: emacs-devel@gnu.org > > I see defconst dir-locals-file-2, but I don't see it being used anywhere. So I thought that the feature was > removed. > > But when you said that emacs-26 still has the feature (yay!), I looked at files.el again.. and of course the > feature is there: > > I see this in dir-locals--all-files: > > (file-2 (when (string-match "\\.el\\'" file-1) > (replace-match "-2.el" t nil file-1))) > > So.. there's an issue, though of a different kind.. may be dir-locals-file-2 mention should be removed? Or > instead be used in the code? But it _is_ used, you just show above the code which uses it. And that's not the only place; see the commit to which you pointed originally for the code which is affected by this second dir-locals file. So I really don't understand what is the issue that needs to be fixed.