From: Eli Zaretskii <eliz@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Relics of removed dir-locals-file-2 feature in pretest
Date: Wed, 22 Nov 2017 18:20:14 +0200 [thread overview]
Message-ID: <83lgiyb801.fsf@gnu.org> (raw)
In-Reply-To: <CAFyQvY20sh63vHV2by3xBH88bhbg+zk_MVJd202TzAOKm9Osww@mail.gmail.com> (message from Kaushal Modi on Wed, 22 Nov 2017 15:58:36 +0000)
> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Wed, 22 Nov 2017 15:58:36 +0000
> Cc: emacs-devel@gnu.org
>
> I see defconst dir-locals-file-2, but I don't see it being used anywhere. So I thought that the feature was
> removed.
>
> But when you said that emacs-26 still has the feature (yay!), I looked at files.el again.. and of course the
> feature is there:
>
> I see this in dir-locals--all-files:
>
> (file-2 (when (string-match "\\.el\\'" file-1)
> (replace-match "-2.el" t nil file-1)))
>
> So.. there's an issue, though of a different kind.. may be dir-locals-file-2 mention should be removed? Or
> instead be used in the code?
But it _is_ used, you just show above the code which uses it. And
that's not the only place; see the commit to which you pointed
originally for the code which is affected by this second dir-locals
file.
So I really don't understand what is the issue that needs to be fixed.
next prev parent reply other threads:[~2017-11-22 16:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 13:58 Relics of removed dir-locals-file-2 feature in pretest Kaushal Modi
2017-11-21 19:56 ` Kaushal Modi
2017-11-21 20:33 ` Eli Zaretskii
2017-11-21 21:11 ` Kaushal Modi
2017-11-22 15:19 ` Eli Zaretskii
2017-11-22 15:58 ` Kaushal Modi
2017-11-22 16:20 ` Eli Zaretskii [this message]
2017-11-22 16:28 ` Kaushal Modi
2017-11-23 15:53 ` Eli Zaretskii
2017-11-23 17:34 ` Kaushal Modi
2017-11-23 20:08 ` Eli Zaretskii
2017-11-27 14:57 ` Kaushal Modi
2017-11-27 16:14 ` Eli Zaretskii
2017-11-27 17:04 ` Kaushal Modi
2017-11-27 17:27 ` Eli Zaretskii
2017-11-27 17:50 ` Kaushal Modi
2017-11-28 17:19 ` Eli Zaretskii
2017-11-28 17:34 ` Kaushal Modi
2017-11-28 17:51 ` Eli Zaretskii
2017-11-28 17:59 ` Kaushal Modi
2017-11-28 20:02 ` Davis Herring
2017-11-28 20:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lgiyb801.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.