From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#25061: consider adding %COMPAT to default gnutls priority string
Date: Wed, 20 Dec 2017 18:19:10 +0200
Message-ID: <83lghxnzi9.fsf@gnu.org>
References: <87zikiwpl6.fsf@igalia.com>
	<CAFyQvY2W4ciqX+RbQfC5VRX+ouxoARYLx5YQvcc+q_hKE7+QOg@mail.gmail.com>
	<87shc6k3tf.fsf@lifelogs.com>
	<CAFyQvY02a=ZZZyzH3FSkOYSAPDpwzVhxUR9Qa3QO9-2gTwEG+w@mail.gmail.com>
	<87bmiujjdg.fsf@lifelogs.com> <vz1d139k19m.fsf@gmail.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1513786699 8016 195.159.176.226 (20 Dec 2017 16:18:19 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Wed, 20 Dec 2017 16:18:19 +0000 (UTC)
Cc: 25061@debbugs.gnu.org
To: Andy Moreton <andrewjmoreton@gmail.com>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 20 17:18:15 2017
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1eRh4P-0001ZW-W0
	for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Dec 2017 17:18:14 +0100
Original-Received: from localhost ([::1]:57858 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1eRh6O-0002Dt-D1
	for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Dec 2017 11:20:16 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53854)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eRh6F-0002Ce-As
	for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2017 11:20:08 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eRh6A-0006mU-PV
	for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2017 11:20:07 -0500
Original-Received: from debbugs.gnu.org ([208.118.235.43]:35968)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eRh6A-0006ly-9l
	for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2017 11:20:02 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eRh6A-0006JT-4U
	for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2017 11:20:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Eli Zaretskii <eliz@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Wed, 20 Dec 2017 16:20:02 +0000
Resent-Message-ID: <handler.25061.B25061.151378675124207@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 25061
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
Original-Received: via spool by 25061-submit@debbugs.gnu.org id=B25061.151378675124207
	(code B ref 25061); Wed, 20 Dec 2017 16:20:02 +0000
Original-Received: (at 25061) by debbugs.gnu.org; 20 Dec 2017 16:19:11 +0000
Original-Received: from localhost ([127.0.0.1]:44649 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1eRh5I-0006IJ-3I
	for submit@debbugs.gnu.org; Wed, 20 Dec 2017 11:19:11 -0500
Original-Received: from eggs.gnu.org ([208.118.235.92]:33171)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <eliz@gnu.org>) id 1eRh5G-0006Ho-LG
	for 25061@debbugs.gnu.org; Wed, 20 Dec 2017 11:19:06 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1eRh56-0005qZ-Uc
	for 25061@debbugs.gnu.org; Wed, 20 Dec 2017 11:19:01 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36335)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1eRh56-0005qR-QW; Wed, 20 Dec 2017 11:18:56 -0500
Original-Received: from [176.228.60.248] (port=3352 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1eRh56-0004ac-70; Wed, 20 Dec 2017 11:18:56 -0500
In-reply-to: <vz1d139k19m.fsf@gmail.com> (message from Andy Moreton on Wed, 20
	Dec 2017 12:54:45 +0000)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
	the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-gnu-emacs/>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: "bug-gnu-emacs"
	<bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.bugs:141295
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/141295>

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Wed, 20 Dec 2017 12:54:45 +0000
> 
> diff --git a/src/gnutls.c b/src/gnutls.c
> index 8db201ae83..f2b078d964 100644
> --- a/src/gnutls.c
> +++ b/src/gnutls.c
> @@ -238,6 +238,7 @@ DEF_DLL_FN (int, gnutls_hash, (gnutls_hash_hd_t, const void *, size_t));
>  DEF_DLL_FN (void, gnutls_hash_deinit, (gnutls_hash_hd_t, void *));
>  DEF_DLL_FN (void, gnutls_hash_output, (gnutls_hash_hd_t, void *));
>  #  endif        /* HAVE_GNUTLS3 */
> +DEF_DLL_FN (const char *, gnutls_ext_get_name, (unsigned int));
> 
> 
>  static bool
> @@ -357,6 +358,7 @@ init_gnutls_functions (void)
>    LOAD_DLL_FN (library, gnutls_hash_deinit);
>    LOAD_DLL_FN (library, gnutls_hash_output);
>  #  endif        /* HAVE_GNUTLS3 */
> +  LOAD_DLL_FN (library, gnutls_ext_get_name);
> 
>    max_log_level = global_gnutls_log_level;
> 
> @@ -470,6 +472,8 @@ init_gnutls_functions (void)
>  #  define gnutls_hash_deinit fn_gnutls_hash_deinit
>  #  define gnutls_hash_output fn_gnutls_hash_output
>  #  endif        /* HAVE_GNUTLS3 */
> +#  define gnutls_ext_get_name fn_gnutls_ext_get_name

Thanks, but this means Emacs will now refuse to load GnuTLS on systems
that have version 3.4 or older of the library, right?  If so, I think
the loading and the use of the function should be conditioned by an
appropriate preprocessor directive to compile that code only for
3.5.X.