From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Date: Tue, 30 Jan 2018 15:49:47 +0200 Message-ID: <83lggfh2x0.fsf@gnu.org> References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> <87k1w1lup5.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1517320204 8405 195.159.176.226 (30 Jan 2018 13:50:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Jan 2018 13:50:04 +0000 (UTC) Cc: stefan@merten-home.de, 30063@debbugs.gnu.org, simenheg@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 30 14:49:59 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egWIM-0001Ya-28 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jan 2018 14:49:54 +0100 Original-Received: from localhost ([::1]:38495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egWKN-0007oq-0b for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jan 2018 08:51:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egWIa-0006ai-I2 for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 08:50:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egWIU-0006U4-U4 for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 08:50:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40779) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egWIU-0006Tu-Pq for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 08:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1egWIU-0001Cs-Hz for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 08:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2018 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.15173201874614 (code B ref 30063); Tue, 30 Jan 2018 13:50:02 +0000 Original-Received: (at 30063) by debbugs.gnu.org; 30 Jan 2018 13:49:47 +0000 Original-Received: from localhost ([127.0.0.1]:48676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egWIF-0001CM-G1 for submit@debbugs.gnu.org; Tue, 30 Jan 2018 08:49:47 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egWID-0001CA-80 for 30063@debbugs.gnu.org; Tue, 30 Jan 2018 08:49:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egWI5-0006Hw-38 for 30063@debbugs.gnu.org; Tue, 30 Jan 2018 08:49:40 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egWI4-0006Ho-VP; Tue, 30 Jan 2018 08:49:37 -0500 Original-Received: from [176.228.60.248] (port=2910 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1egWI4-0003aR-Ay; Tue, 30 Jan 2018 08:49:36 -0500 In-reply-to: <87k1w1lup5.fsf@users.sourceforge.net> (message from Noam Postavsky on Sun, 28 Jan 2018 13:11:34 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142694 Archived-At: > From: Noam Postavsky > Date: Sun, 28 Jan 2018 13:11:34 -0500 > Cc: stefan@merten-home.de, 30063@debbugs.gnu.org > > Simen Heggestøyl writes: > > > (command (format "%s %s %s && %s %s ; rm %s" > > + pdf-compile-program > > buffer-file-name tmp-filename > > rst-pdf-program tmp-filename tmp-filename))) > > + (unless (executable-find pdf-compile-program) > > + (error "Cannot find executable `%s'" pdf-compile-program)) > > + (unless (executable-find rst-pdf-program) > > + (error "Cannot find executable `%s'" rst-pdf-program)) > > It's possible to have PATH and exec-path desynchronized, such that the > above code could throw an error even though the > start-process-shell-command call later would succeed. Maybe we should > should just consider that a misconfiguration on the user's part though. Yes, we could do that. But can we signal an error only when the command fails? That should minimize false negatives. Also please note that the shell command as written is unportable: the ";" part will not work on MS-Windows, we need to use "&" instead. But that's a separate issue.