From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29156: 25.3; eshell/kill does not understand -, [PATCH] Make eshell/kill handle - and - Date: Sat, 17 Mar 2018 10:58:32 +0200 Message-ID: <83lgeroz7r.fsf@gnu.org> References: <87vaiprmg5.fsf@gmail.com> <87o9jnv9et.fsf@gmail.com> <87lgerv8tq.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1521277030 4814 195.159.176.226 (17 Mar 2018 08:57:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Mar 2018 08:57:10 +0000 (UTC) Cc: 29156@debbugs.gnu.org, eric@pagefault.se, ambrevar@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 17 09:57:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ex7eD-00018O-DK for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Mar 2018 09:57:05 +0100 Original-Received: from localhost ([::1]:32901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ex7gG-0001KO-CC for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Mar 2018 04:59:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ex7g9-0001Jw-Uv for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 04:59:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ex7g6-0004Oo-RM for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 04:59:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57831) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ex7g6-0004Og-O1 for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 04:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ex7g6-0006W0-Gr for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 04:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Mar 2018 08:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed easy Original-Received: via spool by 29156-submit@debbugs.gnu.org id=B29156.152127712425020 (code B ref 29156); Sat, 17 Mar 2018 08:59:02 +0000 Original-Received: (at 29156) by debbugs.gnu.org; 17 Mar 2018 08:58:44 +0000 Original-Received: from localhost ([127.0.0.1]:37495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ex7fo-0006VU-B2 for submit@debbugs.gnu.org; Sat, 17 Mar 2018 04:58:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ex7fm-0006VF-GO for 29156@debbugs.gnu.org; Sat, 17 Mar 2018 04:58:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ex7fg-0004HA-I4 for 29156@debbugs.gnu.org; Sat, 17 Mar 2018 04:58:37 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ex7fa-0004FH-4T; Sat, 17 Mar 2018 04:58:30 -0400 Original-Received: from [176.228.60.248] (port=1847 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ex7fZ-0000Cy-HK; Sat, 17 Mar 2018 04:58:29 -0400 In-reply-to: <87lgerv8tq.fsf@gmail.com> (message from Noam Postavsky on Fri, 16 Mar 2018 20:34:25 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144354 Archived-At: > From: Noam Postavsky > Date: Fri, 16 Mar 2018 20:34:25 -0400 > Cc: Eric Skoglund , Pierre Neidhardt > > > ((string-match "\\`-\\([[:upper:]]+\\|[[:lower:]]+\\)\\'" arg) > > - (setq signum (abs (string-to-number arg))))) > > + (setq signum (make-symbol (substring arg 1 (length arg)))))) > > Not sure this `make-symbol' call, should it rather be `intern'? Yes, I think intern is better here. > (Maybe we should update signal-process take a string as well a > symbol.) Possibly. Btw, the doc string of eshell/kill should be updated to reflect the fact we now support symbolic names of Unix signals. Also, NEWS and the Eshell manual should be updated.