From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: 32034@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#32034: 26.1; [PACTH] better xref-location-marker for imperfect file locations
Date: Mon, 02 Jul 2018 20:29:53 +0300 [thread overview]
Message-ID: <83lgatk0ku.fsf@gnu.org> (raw)
In-Reply-To: <87o9fpfuhe.fsf@gmail.com> (message from João Távora on Mon, 02 Jul 2018 17:55:09 +0100)
> From: João Távora <joaotavora@gmail.com>
> Cc: 32034@debbugs.gnu.org, dgutov@yandex.ru
> Date: Mon, 02 Jul 2018 17:55:09 +0100
>
> OK, let's give Dmitry time. But, without trying to annoy you :-) there
> are 3 parts to this:
>
> 1. bug fix for when file doesn't exist (should error instead of making it)
> 2. bug fix for when file exists, but not location (it currently errors)
> 3. new feature, for robustness, search for id around landing point.
>
> 1 and 2 were in my patch. But now I'm assuming you want 1, 2 and 3 in
> emacs-26, in which case I'll try to base the id-searching bit from etags.
No. I'm okay with your solution for 1 to go to emacs-26. I had
reservations about your solution for 2, but now I understand it won't
affect the existing back-ends, so I'm okay with it on emacs-26, too
(but will probably suggest a clearer message text if Dmitry agrees
with the solution).
3 should indeed go to master.
next prev parent reply other threads:[~2018-07-02 17:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 13:46 bug#32034: 26.1; [PACTH] better xref-location-marker for imperfect file locations João Távora
2018-07-02 14:35 ` Robert Pluim
2018-07-02 15:22 ` João Távora
2018-07-02 14:47 ` Eli Zaretskii
2018-07-02 15:28 ` João Távora
2018-07-02 15:37 ` Eli Zaretskii
2018-07-02 15:50 ` João Távora
2018-07-02 16:32 ` Eli Zaretskii
2018-07-02 16:55 ` João Távora
2018-07-02 17:29 ` Eli Zaretskii [this message]
2020-08-10 12:59 ` Lars Ingebrigtsen
2020-08-10 18:53 ` Dmitry Gutov
2020-08-10 20:42 ` João Távora
2018-07-03 13:56 ` Dmitry Gutov
2018-07-03 14:50 ` João Távora
2018-07-03 15:07 ` Dmitry Gutov
2018-07-03 15:43 ` João Távora
2018-07-04 12:58 ` Dmitry Gutov
2018-07-04 13:37 ` João Távora
2018-07-04 14:33 ` Dmitry Gutov
2018-07-04 14:53 ` João Távora
2018-07-04 15:08 ` Dmitry Gutov
2018-07-04 19:16 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lgatk0ku.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32034@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.