From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 32194@debbugs.gnu.org
Subject: bug#32194: [PATCH] Use Gnulib regex for lib-src
Date: Thu, 02 Aug 2018 17:05:09 +0300 [thread overview]
Message-ID: <83lg9ovp7u.fsf@gnu.org> (raw)
In-Reply-To: <15823bbe-8298-0d69-c7a6-edf2001e4513@cs.ucla.edu> (message from Paul Eggert on Tue, 31 Jul 2018 11:21:38 -0700)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Cc: 32194@debbugs.gnu.org
> Date: Tue, 31 Jul 2018 11:21:38 -0700
I've not yet read the patch, will do soon. But one aspect puzzles me:
> > 2. Do we really need to rename src/regex.c? We could have 2 regex.c in
> > separate directories, couldn't we? If possible, I'd prefer not to
> > rename files, as that makes VCS forensics more complicated.
>
> Renaming src/regex.h works around problems with having two include files
> src/regex.h and lib/regex.h that fight each other. I tried not renaming
> src/regex.h at first, and then ran into problems and gave up; although I
> surely could get it to work eventually, I figured that we'd continue to
> have ongoing problems and so it would be better to bite the bullet.
I'm definitely missing something here, because I don't understand why
would these headers "fight" each other. I thought that using
#include "regex.h"
in src/regex.c should avoid any such "fights". But since you no doubt
know about this feature, I wonder what did I miss that would prevent
that from working in this case.
Thanks.
next prev parent reply other threads:[~2018-08-02 14:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 23:47 bug#32194: [PATCH] Use Gnulib regex for lib-src Paul Eggert
2018-07-18 16:34 ` Eli Zaretskii
2018-07-31 18:21 ` Paul Eggert
2018-08-01 0:29 ` Noam Postavsky
2018-08-01 0:59 ` Paul Eggert
2018-08-01 1:10 ` Noam Postavsky
2018-08-01 1:27 ` Paul Eggert
2018-08-02 0:58 ` Noam Postavsky
2018-08-02 1:49 ` Paul Eggert
2018-08-02 1:55 ` Noam Postavsky
2018-08-02 2:42 ` Eli Zaretskii
2018-08-02 3:19 ` Paul Eggert
2018-08-02 10:28 ` Noam Postavsky
2018-08-02 14:05 ` Eli Zaretskii [this message]
2018-08-02 14:41 ` Paul Eggert
2018-08-02 14:55 ` Eli Zaretskii
2018-08-02 15:41 ` Paul Eggert
2018-08-04 15:41 ` Eli Zaretskii
2018-08-04 23:34 ` Paul Eggert
2018-08-05 17:58 ` Eli Zaretskii
2018-08-06 2:40 ` Paul Eggert
2018-08-06 10:59 ` Andy Moreton
2018-08-06 14:52 ` Eli Zaretskii
2018-08-06 15:40 ` Andy Moreton
2018-08-06 14:54 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lg9ovp7u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32194@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.