From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34114: 27.0.50: pdumper and themes with Emacs daemon Date: Thu, 24 Jan 2019 17:11:56 +0200 Message-ID: <83lg3a6qf7.fsf@gnu.org> References: <61329001-3288-47b4-ad82-de16ac532d12@email.android.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="163644"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34114@debbugs.gnu.org, karl@karlotness.com, kaushal.modi@gmail.com To: Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 24 16:13:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmggp-000gSt-VO for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Jan 2019 16:13:12 +0100 Original-Received: from localhost ([127.0.0.1]:55548 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmggo-0000zk-Ri for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Jan 2019 10:13:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmggh-0000zT-Ky for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2019 10:13:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmggg-00015u-R4 for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2019 10:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44874) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmggg-00015F-Nc for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2019 10:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gmggg-0001dS-BL for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2019 10:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Jan 2019 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34114 X-GNU-PR-Package: emacs Original-Received: via spool by 34114-submit@debbugs.gnu.org id=B34114.15483427306217 (code B ref 34114); Thu, 24 Jan 2019 15:13:02 +0000 Original-Received: (at 34114) by debbugs.gnu.org; 24 Jan 2019 15:12:10 +0000 Original-Received: from localhost ([127.0.0.1]:44155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmgfq-0001cD-2g for submit@debbugs.gnu.org; Thu, 24 Jan 2019 10:12:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmgfo-0001bq-7j for 34114@debbugs.gnu.org; Thu, 24 Jan 2019 10:12:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmgfi-0008Mw-Oa; Thu, 24 Jan 2019 10:12:02 -0500 Original-Received: from [176.228.60.248] (port=1244 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gmgfi-0003WH-CY; Thu, 24 Jan 2019 10:12:02 -0500 In-reply-to: <61329001-3288-47b4-ad82-de16ac532d12@email.android.com> (message from Daniel Colascione on Tue, 22 Jan 2019 22:48:59 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154732 Archived-At: > Date: Tue, 22 Jan 2019 22:48:59 -0800 > From: Daniel Colascione > Cc: karl@karlotness.com, 34114@debbugs.gnu.org, kaushal.modi@gmail.com > > We'd still need code to serialize frames. And for what? What would we get with this scheme? Smoother transition, perhaps? Anyway, I've compared the values of some important members of 'struct frame' after restoring from pdump, and didn't see any other problems. So Karl, could you please try the patch below, which is based on your idea, but with a quirk? And before you apply the patch, could you perhaps show C and Lisp backtraces from the errors you were seeing? I don't see those errors here when I try your recipe, and I'd like to better understand where the problem happens. Thanks. diff --git a/src/dispnew.c b/src/dispnew.c index 88783cd..1cafe29 100644 --- a/src/dispnew.c +++ b/src/dispnew.c @@ -6037,7 +6037,18 @@ init_display_interactive (void) except on Windows, where we at least want to initialize it. */ #ifndef WINDOWSNT if (IS_DAEMON) + { + /* Pdump'ed Emacs doesn't record the initial frame from temacs, + so the non-basic faces realized for that frame in temacs + aren't in emacs. This causes errors when users try to + customize those faces in their init file. The call to + init_faces_initial will realize these faces now. (Non-daemon + Emacs does this either near the end of this function or when + the GUI frame is created.) */ + if (dumped_with_pdumper_p ()) + init_faces_initial (); return; + } #endif /* If the user wants to use a window system, we shouldn't bother