From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Colascione <dancol@dancol.org>
Cc: 34114@debbugs.gnu.org, karl@karlotness.com, kaushal.modi@gmail.com
Subject: bug#34114: 27.0.50: pdumper and themes with Emacs daemon
Date: Thu, 24 Jan 2019 17:11:56 +0200 [thread overview]
Message-ID: <83lg3a6qf7.fsf@gnu.org> (raw)
In-Reply-To: <61329001-3288-47b4-ad82-de16ac532d12@email.android.com> (message from Daniel Colascione on Tue, 22 Jan 2019 22:48:59 -0800)
> Date: Tue, 22 Jan 2019 22:48:59 -0800
> From: Daniel Colascione <dancol@dancol.org>
> Cc: karl@karlotness.com, 34114@debbugs.gnu.org, kaushal.modi@gmail.com
>
> We'd still need code to serialize frames. And for what? What would we get with this scheme?
Smoother transition, perhaps?
Anyway, I've compared the values of some important members of 'struct
frame' after restoring from pdump, and didn't see any other problems.
So Karl, could you please try the patch below, which is based on your
idea, but with a quirk?
And before you apply the patch, could you perhaps show C and Lisp
backtraces from the errors you were seeing? I don't see those errors
here when I try your recipe, and I'd like to better understand where
the problem happens.
Thanks.
diff --git a/src/dispnew.c b/src/dispnew.c
index 88783cd..1cafe29 100644
--- a/src/dispnew.c
+++ b/src/dispnew.c
@@ -6037,7 +6037,18 @@ init_display_interactive (void)
except on Windows, where we at least want to initialize it. */
#ifndef WINDOWSNT
if (IS_DAEMON)
+ {
+ /* Pdump'ed Emacs doesn't record the initial frame from temacs,
+ so the non-basic faces realized for that frame in temacs
+ aren't in emacs. This causes errors when users try to
+ customize those faces in their init file. The call to
+ init_faces_initial will realize these faces now. (Non-daemon
+ Emacs does this either near the end of this function or when
+ the GUI frame is created.) */
+ if (dumped_with_pdumper_p ())
+ init_faces_initial ();
return;
+ }
#endif
/* If the user wants to use a window system, we shouldn't bother
next prev parent reply other threads:[~2019-01-24 15:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 11:15 bug#34114: 27.0.50: pdumper and themes with Emacs daemon Karl Otness
2019-01-17 20:01 ` Kaushal Modi
2019-01-17 20:38 ` Kaushal Modi
2019-01-18 23:02 ` Karl Otness
2019-01-18 23:23 ` Daniel Colascione
2019-01-18 23:37 ` Karl Otness
2019-01-18 23:49 ` Daniel Colascione
2019-01-19 0:09 ` Karl Otness
2019-01-19 7:05 ` Eli Zaretskii
2019-01-21 22:59 ` Daniel Colascione
2019-01-22 16:28 ` Kaushal Modi
2019-01-22 16:45 ` Eli Zaretskii
2019-01-23 1:41 ` Daniel Colascione
2019-01-23 3:43 ` Eli Zaretskii
2019-01-23 4:05 ` Daniel Colascione
2019-01-23 5:32 ` Eli Zaretskii
2019-01-23 6:48 ` Daniel Colascione
2019-01-24 15:11 ` Eli Zaretskii [this message]
2019-01-24 19:22 ` Karl Otness
2019-01-26 10:22 ` Eli Zaretskii
2019-01-27 18:40 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lg3a6qf7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34114@debbugs.gnu.org \
--cc=dancol@dancol.org \
--cc=karl@karlotness.com \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.