From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Fri, 08 Feb 2019 18:11:25 +0200 [thread overview]
Message-ID: <83lg2qp8eq.fsf@gnu.org> (raw)
In-Reply-To: <m2d0o2ny4j.fsf@gmail.com> (message from Robert Pluim on Fri, 08 Feb 2019 15:38:52 +0100)
> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 08 Feb 2019 15:38:52 +0100
>
> > That's orthogonal. Regardless of whether we want to drop ftxfont.c, I
> > don't understand why build with both xftfont.c and ftxfont.c. They
> > seem to be mutually exclusive, from the end-user POV.
>
> Removing ftxfont.c from the HAVE_XFT build is the same as dropping it:
>
> configure.ac:
>
> ## We used to allow building with FreeType and without Xft.
> ## However, the ftx font backend driver is not in good shape.
> if test "$HAVE_XFT" != "yes"; then
> dnl For the "Does Emacs use" message at the end.
> HAVE_XFT=no
> HAVE_FREETYPE=no
> else
>
> elif test "$HAVE_XFT" = "yes"; then
> FONT_OBJ="$FONT_OBJ ftfont.o xftfont.o ftxfont.o"
> elif test "$HAVE_FREETYPE" = "yes"; then
> FONT_OBJ="$FONT_OBJ ftfont.o ftxfont.o"
> fi
>
> I donʼt mind either way: as you rightly point out, nobody can possibly
> be using it :-)
The above is strange, since the code which uses font backends clearly
meant something else:
#ifdef USE_CAIRO
register_font_driver (&ftcrfont_driver, f);
#else
#ifdef HAVE_FREETYPE
#ifdef HAVE_XFT
register_font_driver (&xftfont_driver, f);
#else /* not HAVE_XFT */
register_font_driver (&ftxfont_driver, f);
#endif /* not HAVE_XFT */
#endif /* HAVE_FREETYPE */
register_font_driver (&xfont_driver, f);
#endif /* not USE_CAIRO */
Here, xftfont and ftxfont are clearly 2 more-or-less equivalent
alternatives, and bot rely on Freetype. So I don't understand why not
having XFT is taken by configure.ac to mean there's no Freetype,
either. Sounds like a mistake, or did I miss something?
> >> >> I can cherry-pick this to the harfbuzz branch if you want.
> >> >
> >> > Thanks, please do.
> >>
> >> Will do.
> >
> > TIA
>
> Done as 015a6e1df2
Thanks.
next prev parent reply other threads:[~2019-02-08 16:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181214085417.15440.18845@vcs0.savannah.gnu.org>
[not found] ` <20181214085418.6616820538@vcs0.savannah.gnu.org>
2018-12-14 12:18 ` harfbuzz 2f72162: Fix crash in the Cairo build Robert Pluim
2018-12-14 13:29 ` Eli Zaretskii
2018-12-14 14:09 ` Robert Pluim
2018-12-14 16:16 ` Robert Pluim
2018-12-14 16:45 ` Eli Zaretskii
2018-12-17 12:41 ` Robert Pluim
2018-12-17 17:39 ` Eli Zaretskii
2018-12-18 8:49 ` Robert Pluim
2018-12-18 13:01 ` Robert Pluim
2019-02-08 8:01 ` Robert Pluim
2019-02-08 8:04 ` Robert Pluim
2019-02-08 8:06 ` Robert Pluim
2019-02-08 9:37 ` Eli Zaretskii
2019-02-08 11:46 ` Robert Pluim
2019-02-08 13:14 ` Eli Zaretskii
2019-02-08 14:38 ` Robert Pluim
2019-02-08 16:11 ` Eli Zaretskii [this message]
2019-02-08 16:41 ` Robert Pluim
2019-02-08 21:29 ` Eli Zaretskii
2019-02-09 19:20 ` Glenn Morris
2019-02-09 19:34 ` Eli Zaretskii
2019-02-10 14:47 ` Stefan Monnier
2019-02-10 15:28 ` Eli Zaretskii
2019-02-10 18:18 ` Stefan Monnier
2019-02-10 18:48 ` Eli Zaretskii
2019-02-10 18:52 ` Stefan Monnier
2019-02-11 9:56 ` Robert Pluim
2019-02-10 18:30 ` Glenn Morris
2019-02-10 14:57 ` Eli Zaretskii
2019-02-10 18:36 ` Glenn Morris
2019-02-11 15:33 ` Eli Zaretskii
2018-12-17 21:49 ` Paul Eggert
2018-12-18 8:23 ` Robert Pluim
2018-12-19 8:32 ` Robert Pluim
2018-12-19 15:06 ` Eli Zaretskii
2018-12-14 20:25 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lg2qp8eq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.