From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Fri, 03 May 2019 18:10:39 +0300 Message-ID: <83lfznmv4g.fsf@gnu.org> References: <20190407181925.w3aztx44g5drtww2@Ergus> <83pnpx8y67.fsf@gnu.org> <20190407183806.htl4pujrb2kmk4kv@Ergus> <83mul18wpv.fsf@gnu.org> <20190407200514.2p6gfucdcdsrqe47@Ergus> <83ef6d8c40.fsf@gnu.org> <20190408085102.ozcuvs323ilfid7n@Ergus> <83bm1g8s02.fsf@gnu.org> <20190412134633.g47vybtpkwxyw7dq@Ergus> <834l73mir0.fsf@gnu.org> <20190501110808.27o64tawy2gyjocr@Ergus> <83sgtvn08w.fsf@gnu.org> <87ef5ffwv9.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="9570"; mail-complaints-to="usenet@blaine.gmane.org" Cc: spacibba@aol.com, emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 03 23:17:37 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMfYZ-0017On-1y for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 23:17:23 +0200 Original-Received: from localhost ([127.0.0.1]:42006 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMZqt-0007GK-CE for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 11:11:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMZq4-0007Em-CV for emacs-devel@gnu.org; Fri, 03 May 2019 11:11:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMZq4-00070V-62; Fri, 03 May 2019 11:11:04 -0400 Original-Received: from [176.228.60.248] (port=2423 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMZq2-0006MJ-Om; Fri, 03 May 2019 11:11:03 -0400 In-reply-to: <87ef5ffwv9.fsf@tcd.ie> (contovob@tcd.ie) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236125 Archived-At: > From: "Basil L. Contovounesios" > Cc: Ergus , > Date: Fri, 03 May 2019 15:14:50 +0100 > > >> +;; Definition stolen from display-line-numbers. > >> +(defface fill-column-face > >> + '((t :inherit (shadow default))) > >> + "Face for displaying fill column indicator line. > > ^^^^ > > I'd drop the "line" part. You allude to the shape of the indicator > > character, but it doesn't have to look like a line, and using "line" > > is confusing here. > > I'm not sure how closely this convention is followed in new code, but > FWIW the defface docs under (info "(elisp) Defining Faces") say: > > -- Macro: defface face spec doc [keyword value]... > This macro declares FACE as a named face whose default face spec is > given by SPEC. You should not quote the symbol FACE, and it should > not end in ‘-face’ (that would be redundant). > ^^^^^^^^^^^^^^^^^^ If you drop the -face part in this case, you are left with fill-column, and we already have a variable by that name. So in this case following that rule would be detrimental, I'd say. Also, I think this name follows what fci-mode did.