From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: extract_data_from_object considered dangerous
Date: Mon, 23 Sep 2019 05:28:31 +0300
Message-ID: <83lfufpwz4.fsf@gnu.org>
References: <jwv5zlke9nx.fsf-monnier+emacs@gnu.org> <83woe0p961.fsf@gnu.org>
 <jwvh854hx5t.fsf-monnier+emacs@gnu.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="211693"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 23 04:29:11 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iCE6A-000swo-Qb
	for ged-emacs-devel@m.gmane.org; Mon, 23 Sep 2019 04:29:10 +0200
Original-Received: from localhost ([::1]:51832 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iCE69-0005q6-OW
	for ged-emacs-devel@m.gmane.org; Sun, 22 Sep 2019 22:29:09 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60778)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1iCE5N-0005px-T4
 for emacs-devel@gnu.org; Sun, 22 Sep 2019 22:28:22 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41063)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1iCE5N-0001V4-II; Sun, 22 Sep 2019 22:28:21 -0400
Original-Received: from [176.228.60.248] (port=3720 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1iCE5M-0003Tx-E4; Sun, 22 Sep 2019 22:28:21 -0400
In-reply-to: <jwvh854hx5t.fsf-monnier+emacs@gnu.org> (message from Stefan
 Monnier on Sun, 22 Sep 2019 16:53:05 -0400)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:240256
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/240256>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sun, 22 Sep 2019 16:53:05 -0400
> 
> > If we want to lift this restriction, I think the
> > function should return a Lisp object, not a char *.
> 
> That's also my impression, but I was wondering is there was a good
> reason why it wasn't done this way in the first place.

AFAIR, the function was created by consolidating many repeated in-line
code fragments.