From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: cc-mode Objective C method names
Date: Wed, 01 Jan 2020 18:41:05 +0200
Message-ID: <83lfqrjfj2.fsf@gnu.org>
References: <20200101112757.GA41966@breton.holly.idiocy.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="233360"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Alan Third <alan@idiocy.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 01 17:41:26 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1imh3j-000yWj-KL
	for ged-emacs-devel@m.gmane.org; Wed, 01 Jan 2020 17:41:23 +0100
Original-Received: from localhost ([::1]:59880 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1imh3i-0003Dm-9v
	for ged-emacs-devel@m.gmane.org; Wed, 01 Jan 2020 11:41:22 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40651)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1imh3E-0002ob-8s
 for emacs-devel@gnu.org; Wed, 01 Jan 2020 11:40:53 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38249)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1imh3D-0007jt-Rr; Wed, 01 Jan 2020 11:40:51 -0500
Original-Received: from [176.228.60.248] (port=1555 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1imh3D-0004Yr-71; Wed, 01 Jan 2020 11:40:51 -0500
In-reply-to: <20200101112757.GA41966@breton.holly.idiocy.org> (message from
 Alan Third on Wed, 1 Jan 2020 11:27:57 +0000)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:243840
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/243840>

> Date: Wed, 1 Jan 2020 11:27:57 +0000
> From: Alan Third <alan@idiocy.org>
> 
> It appears to work for me, but I’m not great at Emacs lisp so I
> thought it best to run this by the mailing list in case I’ve made any
> boneheaded errors.

A few minor nits below:

> +		(type (buffer-substring-no-properties (point) (+ (point) 1)))

I'd use instead

                (type (char-after))

(You'll also need to change the format to use %c instead of %s.)

> +		   (let ((name ""))

There's no need to initialize 'name' to an empty string, because
'append' can DTRT with nil as well:

   (append nil "foo") => "foo"

So just
                   (let (name)

should do.