all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: emacs-devel@gnu.org
Subject: Re: cc-mode Objective C method names
Date: Wed, 01 Jan 2020 18:41:05 +0200	[thread overview]
Message-ID: <83lfqrjfj2.fsf@gnu.org> (raw)
In-Reply-To: <20200101112757.GA41966@breton.holly.idiocy.org> (message from Alan Third on Wed, 1 Jan 2020 11:27:57 +0000)

> Date: Wed, 1 Jan 2020 11:27:57 +0000
> From: Alan Third <alan@idiocy.org>
> 
> It appears to work for me, but I’m not great at Emacs lisp so I
> thought it best to run this by the mailing list in case I’ve made any
> boneheaded errors.

A few minor nits below:

> +		(type (buffer-substring-no-properties (point) (+ (point) 1)))

I'd use instead

                (type (char-after))

(You'll also need to change the format to use %c instead of %s.)

> +		   (let ((name ""))

There's no need to initialize 'name' to an empty string, because
'append' can DTRT with nil as well:

   (append nil "foo") => "foo"

So just
                   (let (name)

should do.



  parent reply	other threads:[~2020-01-01 16:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-01 11:27 cc-mode Objective C method names Alan Third
2020-01-01 15:29 ` Stefan Monnier
2020-01-02 11:02   ` Alan Third
2020-01-01 16:41 ` Eli Zaretskii [this message]
2020-01-04 10:48 ` Alan Mackenzie
2020-01-04 11:07   ` HaiJun Zhang
2020-01-04 17:09   ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lfqrjfj2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.