From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks Date: Tue, 31 Mar 2020 17:40:31 +0300 Message-ID: <83lfng1tb4.fsf@gnu.org> References: <87k131myzf.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="56572"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, stepnem@gmail.com, 40332@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 31 16:41:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJI4o-000Eb5-2G for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Mar 2020 16:41:14 +0200 Original-Received: from localhost ([::1]:39188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJI4n-0004KH-08 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Mar 2020 10:41:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52842) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJI4d-0004Jm-HF for bug-gnu-emacs@gnu.org; Tue, 31 Mar 2020 10:41:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJI4c-0002YJ-K1 for bug-gnu-emacs@gnu.org; Tue, 31 Mar 2020 10:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53457) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJI4c-0002Y2-6j for bug-gnu-emacs@gnu.org; Tue, 31 Mar 2020 10:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jJI4c-00067U-1S for bug-gnu-emacs@gnu.org; Tue, 31 Mar 2020 10:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Mar 2020 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40332 X-GNU-PR-Package: emacs Original-Received: via spool by 40332-submit@debbugs.gnu.org id=B40332.158566562623457 (code B ref 40332); Tue, 31 Mar 2020 14:41:01 +0000 Original-Received: (at 40332) by debbugs.gnu.org; 31 Mar 2020 14:40:26 +0000 Original-Received: from localhost ([127.0.0.1]:36770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJI42-00066H-Df for submit@debbugs.gnu.org; Tue, 31 Mar 2020 10:40:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJI41-000662-9Z for 40332@debbugs.gnu.org; Tue, 31 Mar 2020 10:40:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jJI3v-0002Cd-Rx; Tue, 31 Mar 2020 10:40:19 -0400 Original-Received: from [176.228.60.248] (port=2438 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jJI3v-0001Dj-6C; Tue, 31 Mar 2020 10:40:19 -0400 In-Reply-To: (message from Stefan Monnier on Mon, 30 Mar 2020 15:47:17 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177914 Archived-At: > From: Stefan Monnier > Date: Mon, 30 Mar 2020 15:47:17 -0400 > Cc: 40332-done@debbugs.gnu.org, Yuan Fu > > + ;; We used to bind `inhibit-modification-hooks' to try and speed up > + ;; execution, in particular, to prevent the font-lock hook from running > + ;; until the directory is all read in. > + ;; I strongly suspect that this was only useful in Emacs<21, because > + ;; jit-lock made it a non-issue. > + ;; Nevertheless, I used `combine-change-calls' which provides the > + ;; same performance advantages, just in case. FWIW, according to "git log", the change which introduced inhibit-modification-hooks was made by RMS in Dec 2008, so it's unlikely that had anything to do with Emacs before v21. Maybe we should augment that part of the comment?