From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: casouri@gmail.com, stepnem@gmail.com, 40332@debbugs.gnu.org
Subject: bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks
Date: Tue, 31 Mar 2020 17:40:31 +0300 [thread overview]
Message-ID: <83lfng1tb4.fsf@gnu.org> (raw)
In-Reply-To: <jwvh7y5mxxu.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Mon, 30 Mar 2020 15:47:17 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 30 Mar 2020 15:47:17 -0400
> Cc: 40332-done@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>
>
> + ;; We used to bind `inhibit-modification-hooks' to try and speed up
> + ;; execution, in particular, to prevent the font-lock hook from running
> + ;; until the directory is all read in.
> + ;; I strongly suspect that this was only useful in Emacs<21, because
> + ;; jit-lock made it a non-issue.
> + ;; Nevertheless, I used `combine-change-calls' which provides the
> + ;; same performance advantages, just in case.
FWIW, according to "git log", the change which introduced
inhibit-modification-hooks was made by RMS in Dec 2008, so it's
unlikely that had anything to do with Emacs before v21. Maybe we
should augment that part of the comment?
next prev parent reply other threads:[~2020-03-31 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 19:20 bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks Štěpán Němec
2020-03-30 19:47 ` Stefan Monnier
2020-03-30 20:03 ` Štěpán Němec
2020-03-31 14:40 ` Eli Zaretskii [this message]
2020-03-31 15:13 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lfng1tb4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=40332@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=stepnem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.