From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 27 face :extend attribute not working with pulse.el? Date: Thu, 09 Apr 2020 16:51:27 +0300 Message-ID: <83lfn4ojhc.fsf@gnu.org> References: <875ze8iza9.fsf@alphapapa.net> <87y2r4hk58.fsf@alphapapa.net> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="82555"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 09 15:52:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMXbh-000LOS-Mw for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Apr 2020 15:52:37 +0200 Original-Received: from localhost ([::1]:49706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMXbg-0002q7-O1 for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Apr 2020 09:52:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33397) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMXat-0001qI-JZ for emacs-devel@gnu.org; Thu, 09 Apr 2020 09:51:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jMXat-000471-9O; Thu, 09 Apr 2020 09:51:47 -0400 Original-Received: from [176.228.60.248] (port=4509 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jMXas-00024n-JM; Thu, 09 Apr 2020 09:51:47 -0400 In-Reply-To: <87y2r4hk58.fsf@alphapapa.net> (message from Adam Porter on Thu, 09 Apr 2020 08:18:59 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246711 Archived-At: > From: Adam Porter > Date: Thu, 09 Apr 2020 08:18:59 -0500 > > > I think this issue may be in pulse.el, because evaluating this code has > > the same problem: > > > > (pulse-momentary-highlight-one-line (point)) > > After further investigation, I've found that setting ":extend t" on the > pulse-highlight-face seems to fix the problem and restore the behavior > seen in Emacs 26.3. Yes, that is the right solution, I think. But the default should stay with the :extend attribute nil, IMO. > This seems like an obvious, easy fix to restore the previous behavior, > but I don't know if it's the "correct" one, because it appears to have > the side effect of forcing extension even when > pulse-momentary-highlight-one-line is called with a face argument which > does not have ":extend t" set. Does the patch below produce good results? diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el index 16243e1..8649254 100644 --- a/lisp/cedet/pulse.el +++ b/lisp/cedet/pulse.el @@ -161,6 +161,9 @@ pulse-reset-face (face-background face nil t) (face-background 'pulse-highlight-start-face) )) + (and face + (set-face-extend 'pulse-highlight-face + (face-extend-p face nil t))) (put 'pulse-highlight-face :startface (or face 'pulse-highlight-start-face)) (put 'pulse-highlight-face :iteration 0)) P.S. And *please* in the future report bugs with report-emacs-bug. It is tedious to have to mention the URL of emacs-devel discussion in the log message, instead of just mentioning the bug number.