From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 6057d79 * doc/lispref/keymaps.texi (Extended Menu Items): Tweak :key-sequence Date: Sun, 19 Apr 2020 18:11:35 +0300 Message-ID: <83lfmrik7s.fsf@gnu.org> References: <835ze6msew.fsf@gnu.org> <837dydaz7u.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="28347"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 19 17:12:29 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jQBcS-0007Il-TP for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Apr 2020 17:12:28 +0200 Original-Received: from localhost ([::1]:42808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQBcR-00043O-V5 for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Apr 2020 11:12:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55938) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQBbj-0003IG-Dk for emacs-devel@gnu.org; Sun, 19 Apr 2020 11:11:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52533) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQBbi-0003s9-RV; Sun, 19 Apr 2020 11:11:42 -0400 Original-Received: from [176.228.60.248] (port=1248 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jQBbh-0005M7-L0; Sun, 19 Apr 2020 11:11:42 -0400 In-Reply-To: (message from Stefan Monnier on Sun, 19 Apr 2020 10:42:46 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247318 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Sun, 19 Apr 2020 10:42:46 -0400 > > >> @item :key-sequence @var{key-sequence} > >> This property specifies which key sequence is likely to be bound to the > >> -same command invoked by this menu item. If you specify the right key > >> -sequence, that makes preparing the menu for display run much faster. > >> +same command invoked by this menu item. If you specify a correct key > >> +sequence, that sequence will be preferred over others. > >> ^^^^^^^^^^^^^^^^^ > >> In what sense will that sequence be "preferred" in this case? > >> Also, I see that easymenu.el still claims that there's a speed > >> advantage to using :key-sequence. > > Indeed. > > How 'bout the patch below? I'm still not really satisfied (and I think > removing the duplication would also be good). The new text is clear, thanks. I think this should go to the release branch. I'm also okay with removing the duplication (e.g., how about having a cross-reference in one of the places pointing to the other one?) Thanks.