From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 6057d79 * doc/lispref/keymaps.texi (Extended Menu Items): Tweak :key-sequence
Date: Sun, 19 Apr 2020 18:11:35 +0300 [thread overview]
Message-ID: <83lfmrik7s.fsf@gnu.org> (raw)
In-Reply-To: <jwva7375yiv.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sun, 19 Apr 2020 10:42:46 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sun, 19 Apr 2020 10:42:46 -0400
>
> >> @item :key-sequence @var{key-sequence}
> >> This property specifies which key sequence is likely to be bound to the
> >> -same command invoked by this menu item. If you specify the right key
> >> -sequence, that makes preparing the menu for display run much faster.
> >> +same command invoked by this menu item. If you specify a correct key
> >> +sequence, that sequence will be preferred over others.
> >> ^^^^^^^^^^^^^^^^^
> >> In what sense will that sequence be "preferred" in this case?
> >> Also, I see that easymenu.el still claims that there's a speed
> >> advantage to using :key-sequence.
>
> Indeed.
>
> How 'bout the patch below? I'm still not really satisfied (and I think
> removing the duplication would also be good).
The new text is clear, thanks. I think this should go to the release
branch.
I'm also okay with removing the duplication (e.g., how about having a
cross-reference in one of the places pointing to the other one?)
Thanks.
next prev parent reply other threads:[~2020-04-19 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 6:45 [Emacs-diffs] master 6057d79 * doc/lispref/keymaps.texi (Extended Menu Items): Tweak :key-sequence Eli Zaretskii
2020-04-18 10:02 ` Eli Zaretskii
2020-04-19 14:42 ` Stefan Monnier
2020-04-19 15:11 ` Eli Zaretskii [this message]
2020-04-20 2:17 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lfmrik7s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.