How to get the actual face attribute?

How to get the actual face attribute?

[Yuan Fu]

Hi,

When writing my package I need to get height of the face at point. But `face-attribute` doesn’t take face remapping into account, which gives wrong answers. Is there a reliable way to get the actual face attribute that’s used for display? Thanks.

Yuan

Re: How to get the actual face attribute?

[Eli Zaretskii]

> From: Yuan Fu <casouri@gmail.com>
> Date: Sun, 21 Jun 2020 00:01:37 -0400
> 
> When writing my package I need to get height of the face at point. But `face-attribute` doesn’t take face remapping into account, which gives wrong answers. Is there a reliable way to get the actual face attribute that’s used for display? Thanks.

From Lisp or from C?

In general, you cannot know that except by displaying that text or
emulating its display, because the face is fully realized only while
displaying text that is affected by the face.

Re: How to get the actual face attribute?

[Yuan Fu]

> On Jun 21, 2020, at 10:52 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sun, 21 Jun 2020 00:01:37 -0400
>> 
>> When writing my package I need to get height of the face at point. But `face-attribute` doesn’t take face remapping into account, which gives wrong answers. Is there a reliable way to get the actual face attribute that’s used for display? Thanks.
> 
> From Lisp or from C?

From Lisp.

> 
> In general, you cannot know that except by displaying that text or
> emulating its display, because the face is fully realized only while
> displaying text that is affected by the face.
> 

I see, then I will use some ad-hoc check to produce a mostly-right answer. Thanks.

Yuan

Re: How to get the actual face attribute?

[Eli Zaretskii]

> From: Yuan Fu <casouri@gmail.com>
> Date: Sun, 21 Jun 2020 10:55:38 -0400
> Cc: help-gnu-emacs@gnu.org
> 
> >> When writing my package I need to get height of the face at point. But `face-attribute` doesn’t take face remapping into account, which gives wrong answers. Is there a reliable way to get the actual face attribute that’s used for display? Thanks.
> > 
> > From Lisp or from C?
> 
> From Lisp.

You could try calling vertical-motion to move past that line, then use
posn-at-point in the position where you arrived to see how many pixels
you moved.  (Completely untested.)

Re: How to get the actual face attribute?

[Stefan Monnier]

> When writing my package I need to get height of the face at point.

Note that there may be simultaneously several different such heights if
point is shown simultaneously in different frames.


        Stefan

Re: How to get the actual face attribute?

[Yuan Fu]

> On Jun 21, 2020, at 11:54 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>> When writing my package I need to get height of the face at point.
> 
> Note that there may be simultaneously several different such heights if
> point is shown simultaneously in different frames.
> 
> 
>        Stefan
> 
> 

Thanks. Unfortunately I think I asked an x-y question. What I really want to know is the width of the glyph and I thought I can just multiply the height factor to the original width of the glyph. It seems not to be the case. The multiplied result doesn’t match with the width on glass. More precisely :height * glyph width != posn of point after - posn of point. Is this expected?

Also I can’t use posn for calculation since sometimes the text might not be on screen. 

Yuan

Re: How to get the actual face attribute?

[Perry Smith]

> On Jun 22, 2020, at 12:00 PM, Yuan Fu <casouri@gmail.com> wrote:
> 
> 
> 
>> On Jun 21, 2020, at 11:54 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> 
>>> When writing my package I need to get height of the face at point.
>> 
>> Note that there may be simultaneously several different such heights if
>> point is shown simultaneously in different frames.
>> 
> 
> Thanks. Unfortunately I think I asked an x-y question. What I really want to know is the width of the glyph and I thought I can just multiply the height factor to the original width of the glyph. It seems not to be the case. The multiplied result doesn’t match with the width on glass. More precisely :height * glyph width != posn of point after - posn of point. Is this expected?
> 
> Also I can’t use posn for calculation since sometimes the text might not be on screen. 

It might help to explain what the bigger objective is.

Re: How to get the actual face attribute?

[Yuan Fu]

> On Jun 22, 2020, at 1:15 PM, Perry Smith <pedz@easesoftware.com> wrote:
> 
> 
> 
>> On Jun 22, 2020, at 12:00 PM, Yuan Fu <casouri@gmail.com <mailto:casouri@gmail.com>> wrote:
>> 
>> 
>> 
>>> On Jun 21, 2020, at 11:54 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>>> 
>>>> When writing my package I need to get height of the face at point.
>>> 
>>> Note that there may be simultaneously several different such heights if
>>> point is shown simultaneously in different frames.
>>> 
>> 
>> Thanks. Unfortunately I think I asked an x-y question. What I really want to know is the width of the glyph and I thought I can just multiply the height factor to the original width of the glyph. It seems not to be the case. The multiplied result doesn’t match with the width on glass. More precisely :height * glyph width != posn of point after - posn of point. Is this expected?
>> 
>> Also I can’t use posn for calculation since sometimes the text might not be on screen. 
> 
> It might help to explain what the bigger objective is.

I have a package that aligns org tables even for variable pitch text, CJK text, images, etc are in the table:



Some one reported that when they change the text size with text-scale-adjust, the alignment are messed up. That’s because the package aligns by calculating the pixel width of each cell, and when the text size are adjusted that width is no accurate anymore. I’m using this function to calculate the width of a glyph (which adds up to the width of a cell):

(let* ((p (or point (point))))
    (if (eq (char-after point) ?\t)
        (valign--tab-width (font-at p))
      ;; (font-at 0 nil (buffer-substring p (1+ p))) doesn’t work, the
      ;; font is sometimes wrong.  (font-at p) doesn’t work, because
      ;; it requires the buffer to be visible.
      (aref (aref (font-get-glyphs (font-at p) p (1+ p)) 0) 4)))

Yuan

Re: How to get the actual face attribute?

[Eli Zaretskii]

> From: Yuan Fu <casouri@gmail.com>
> Date: Mon, 22 Jun 2020 13:21:15 -0400
> Cc: help-gnu-emacs@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
> 
> I have a package that aligns org tables even for variable pitch text, CJK text, images, etc are in the table:
> 
> 
> 
> Some one reported that when they change the text size with text-scale-adjust, the alignment are messed up. That’s because the package aligns by calculating the pixel width of each cell, and when the text size are adjusted that width is no accurate anymore. I’m using this function to calculate the width of a glyph (which adds up to the width of a cell):
> 
> (let* ((p (or point (point))))
>     (if (eq (char-after point) ?\t)
>         (valign--tab-width (font-at p))
>       ;; (font-at 0 nil (buffer-substring p (1+ p))) doesn’t work, the
>       ;; font is sometimes wrong.  (font-at p) doesn’t work, because
>       ;; it requires the buffer to be visible.
>       (aref (aref (font-get-glyphs (font-at p) p (1+ p)) 0) 4)))

Did you try using window-text-pixel-size?

Re: How to get the actual face attribute?

[Yuan Fu]

> 
> Did you try using window-text-pixel-size?
> 

That requires the buffer to be in a live window so I decided to roll my own measuring function. Now it seems changing my package’s design to accommodate that will work better than using my custom function. (Posn can’t work because it requires all the text to be on glass, which my package can’t work with.) Thanks!

Yuan

Re: How to get the actual face attribute?

[Stefan Monnier]

> Some one reported that when they change the text size with
> text-scale-adjust, the alignment are messed up.

If the alignment is done before changing the text-scale, then it's no
big surprise, since text-scale won't scale everything by the same factor.

IOW, when/where do you do the alignment and trigger re-alignment when
things change (like text-scale, for example)?


        Stefan

Re: How to get the actual face attribute?

[Yuan Fu]

> On Jun 22, 2020, at 2:56 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>> Some one reported that when they change the text size with
>> text-scale-adjust, the alignment are messed up.
> 
> If the alignment is done before changing the text-scale, then it's no
> big surprise, since text-scale won't scale everything by the same factor.
> 

I see. I calculate the text size base on the assumption that the text scale is the same for all glyphs. That explains why my measuring are off.

Yuan

Re: How to get the actual face attribute?

[Stefan Monnier]

>>> Some one reported that when they change the text size with
>>> text-scale-adjust, the alignment are messed up.
>> If the alignment is done before changing the text-scale, then it's no
>> big surprise, since text-scale won't scale everything by the same factor.
> I see. I calculate the text size base on the assumption that the text scale
> is the same for all glyphs. That explains why my measuring are off.

I don't know what that means.  The text-scale does apply globally.
But it doesn't necessarily scale by the same factor horizontally and
vertically, nor does it necessarily scale by the same factor for
different fonts.  It's "more or less equal" but not exactly.  And of
course, it won't affect those glyphs whose size is not relative to the
base `default` face (e.g. images or glyphs to which a face is applied
which sets an absolute rather than relative size).

IOW it needs to be recomputed from scratch when the text-scale is changed.


        Stefan

Re: How to get the actual face attribute?

[Yuan Fu]

> On Jun 22, 2020, at 3:49 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>>>> Some one reported that when they change the text size with
>>>> text-scale-adjust, the alignment are messed up.
>>> If the alignment is done before changing the text-scale, then it's no
>>> big surprise, since text-scale won't scale everything by the same factor.
>> I see. I calculate the text size base on the assumption that the text scale
>> is the same for all glyphs. That explains why my measuring are off.
> 
> I don't know what that means.  The text-scale does apply globally.
> But it doesn't necessarily scale by the same factor horizontally and
> vertically, nor does it necessarily scale by the same factor for
> different fonts.  It's "more or less equal" but not exactly.  And of
> course, it won't affect those glyphs whose size is not relative to the
> base `default` face (e.g. images or glyphs to which a face is applied
> which sets an absolute rather than relative size).
> 
> IOW it needs to be recomputed from scratch when the text-scale is changed.

How should I recompute the text scale? Currently I calculate it from

(expt text-scale-mode-step text-scale-mode-amount)

Which is what text-scale-mode uses. (Face remap is hard to calculate so I thought I can just support text-scale-mode.)

Yuan

Re: How to get the actual face attribute?

[Stefan Monnier]

> How should I recompute the text scale? Currently I calculate it from
>
> (expt text-scale-mode-step text-scale-mode-amount)
>
> Which is what text-scale-mode uses. (Face remap is hard to calculate so
> I thought I can just support text-scale-mode.)

You shouldn't look at `text-scale-*` at all and instead ask the display
code which font it will use.

[ But note that there's the issue of *computing* and then there's the
  issue of *re*computing (i.e. how to detect when it needs to be
  refreshed and how to make sure it is refreshed then).  ]


-- Stefan

Emacs hackers all around the world (was: Re: How to get the actual face attribute?)

[Emanuel Berg via Users list for the GNU Emacs text editor]

Stefan Monnier wrote:

> [ But note that there's the issue of *computing*
>   and then there's the issue of *re*computing (i.e.
>   how to detect when it needs to be refreshed and
>   how to make sure it is refreshed then). ]

That's difficult - recomputing - even
Mr. Monnier would hesitate just a fraction's second
before he did it :)

My birthday's today, so love to all Emacs, Lisp, and
C hackers all around the world <3

Amd as always, sorry if I did and said stupid things.
When it comes to your .emacs and .gnus, but also
.emanuel-berg actually, there is always room for
improvements :)

re: font colors, here is some inspiration. Black and
white, just a little bit bold black, bright white, or
aligned, tilted green, perhaps?

  https://dataswamp.org/~incal/pimgs/baw.png

  https://dataswamp.org/~incal/pimgs/black.jpg

  https://dataswamp.org/~incal/pimgs/champs.png

  https://dataswamp.org/~incal/pimgs/green.png


-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: How to get the actual face attribute?

[Yuan Fu]

> On Jun 22, 2020, at 5:05 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>> How should I recompute the text scale? Currently I calculate it from
>> 
>> (expt text-scale-mode-step text-scale-mode-amount)
>> 
>> Which is what text-scale-mode uses. (Face remap is hard to calculate so
>> I thought I can just support text-scale-mode.)
> 
> You shouldn't look at `text-scale-*` at all and instead ask the display
> code which font it will use.
> 
> [ But note that there's the issue of *computing* and then there's the
>  issue of *re*computing (i.e. how to detect when it needs to be
>  refreshed and how to make sure it is refreshed then).  ]
> 

Right. I just advised text-scale functions for now. I think that should work for most of the use cases.

Yuan

Re: How to get the actual face attribute?

[Emanuel Berg via Users list for the GNU Emacs text editor]

Yuan Fu wrote:

> (let* ((p (or point (point))))
>     (if (eq (char-after point) ?\t)
>         (valign--tab-width (font-at p))
>       ;; (font-at 0 nil (buffer-substring p (1+ p))) doesn’t work, the
>       ;; font is sometimes wrong.  (font-at p) doesn’t work, because
>       ;; it requires the buffer to be visible.
>       (aref (aref (font-get-glyphs (font-at p) p (1+ p)) 0) 4)))

Hello Yuan Fu, you have a cool name :)

re: code, the byte compiler is always your friend:

    geh.el: 
    In do-something:
    geh.el:10:17:Warning: reference to free variable ‘point’

    In end of data:
    geh.el:110:1:Warning: the function ‘valign--tab-width’ is not known to be
        defined.

Also style point #1:

  (aref (aref (font-get-glyphs (font-at p) p (1+ p)) 0) 4)))

Suggestion, break it up, do more `let*'.

ditto #2:

  (or point (point))

Straight long-ear [1] use of `or' :) However the
particular

  point (point) 

is confusing IMO.

ditto #3:

  ... 0) 4)))

hard-coded data can also be put into `let*' to
increase clarity, however if they only appear once
one is allowed... heh :) one is allowed to have them
hard-coded. if they ever appear twice names,
variables/bindings are compulsory, with the possible
exceptions of -1, 0, 1, nil and t :)

Keep 'em coming...


[1] https://en.wikipedia.org/wiki/Hanau_epe

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: How to get the actual face attribute?

[Yuan Fu]

> On Jun 22, 2020, at 5:27 PM, Emanuel Berg via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org> wrote:
> 
> Yuan Fu wrote:
> 
>> (let* ((p (or point (point))))
>>    (if (eq (char-after point) ?\t)
>>        (valign--tab-width (font-at p))
>>      ;; (font-at 0 nil (buffer-substring p (1+ p))) doesn’t work, the
>>      ;; font is sometimes wrong.  (font-at p) doesn’t work, because
>>      ;; it requires the buffer to be visible.
>>      (aref (aref (font-get-glyphs (font-at p) p (1+ p)) 0) 4)))
> 
> Hello Yuan Fu, you have a cool name :)
> 
> re: code, the byte compiler is always your friend:
> 
>    geh.el: 
>    In do-something:
>    geh.el:10:17:Warning: reference to free variable ‘point’
> 
>    In end of data:
>    geh.el:110:1:Warning: the function ‘valign--tab-width’ is not known to be
>        defined.
> 
> Also style point #1:
> 
>  (aref (aref (font-get-glyphs (font-at p) p (1+ p)) 0) 4)))
> 
> Suggestion, break it up, do more `let*'.
> 
> ditto #2:
> 
>  (or point (point))
> 
> Straight long-ear [1] use of `or' :) However the
> particular
> 
>  point (point) 
> 
> is confusing IMO.
> 

It’s used to support optional argument POINT.

> ditto #3:
> 
>  ... 0) 4)))
> 
> hard-coded data can also be put into `let*' to
> increase clarity, however if they only appear once
> one is allowed... heh :) one is allowed to have them
> hard-coded. if they ever appear twice names,
> variables/bindings are compulsory, with the possible
> exceptions of -1, 0, 1, nil and t :)

Ok, I’ll use more let next time. Thanks!

Yuan