From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42943: 28.0.50; Emacsclient crashes in ftcrfont_glyph_extents Date: Sat, 24 Oct 2020 14:46:29 +0300 Message-ID: <83lffvhmne.fsf@gnu.org> References: <877dtuta6z.fsf@tcd.ie> <87y2m82ix4.fsf@gnus.org> <87zh4emnzm.fsf@gnus.org> <87lffxlxm5.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30752"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, larsi@gnus.org, 42943@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 24 13:47:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWI0y-0007uN-P2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Oct 2020 13:47:16 +0200 Original-Received: from localhost ([::1]:53894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWI0x-000661-JY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Oct 2020 07:47:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWI0k-000648-2t for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 07:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWI0j-0003UG-QB for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 07:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWI0j-0004fy-OE for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 07:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Oct 2020 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42943 X-GNU-PR-Package: emacs Original-Received: via spool by 42943-submit@debbugs.gnu.org id=B42943.160354001317959 (code B ref 42943); Sat, 24 Oct 2020 11:47:01 +0000 Original-Received: (at 42943) by debbugs.gnu.org; 24 Oct 2020 11:46:53 +0000 Original-Received: from localhost ([127.0.0.1]:32846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWI0a-0004fb-MJ for submit@debbugs.gnu.org; Sat, 24 Oct 2020 07:46:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWI0Z-0004fO-BW for 42943@debbugs.gnu.org; Sat, 24 Oct 2020 07:46:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45623) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWI0S-0003Sy-9S; Sat, 24 Oct 2020 07:46:45 -0400 Original-Received: from [176.228.60.248] (port=3136 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kWI0R-0007Wj-II; Sat, 24 Oct 2020 07:46:43 -0400 In-Reply-To: (message from Robert Pluim on Sat, 24 Oct 2020 13:24:42 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191417 Archived-At: > From: Robert Pluim > Cc: Lars Ingebrigtsen , 42943@debbugs.gnu.org, eliz@gnu.org > Date: Sat, 24 Oct 2020 13:24:42 +0200 > > The call to ftcrfont_glyph_extents is from here: > > static int > ftcrfont_draw (struct glyph_string *s, > int from, int to, int x, int y, bool with_background) > { > struct frame *f = s->f; > struct face *face = s->face; > struct font_info *ftcrfont_info = (struct font_info *) s->font; > > So this means that the struct glyph_string here still refers to the > font from the previous frame, which has been closed. Iʼm not sure how > to get it to refer to the right font on the new frame. I'm guessing that we close the font, but there's still a face that references that font, and we try using that face for display. Can you see if that is the case? The 'face' member of 'struct glyph_string' should point to the face, and face->font should point to the font. We call font_clear_cache when a frame is deleted, so it's unclear to me how come the font is still remembered somewhere. And I lack some background here: what is/are the character(s) we try displaying here, and how that display is triggered by creating a new frame due to the second emacsclient invocation?