From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Date: Tue, 27 Apr 2021 22:19:22 +0300 Message-ID: <83lf93h6x1.fsf@gnu.org> References: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12847"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48072@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 27 21:20:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbTFk-0002vI-5G for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Apr 2021 21:20:12 +0200 Original-Received: from localhost ([::1]:52374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbTFj-00015o-8O for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Apr 2021 15:20:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbTFa-00015c-Qh for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 15:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39403) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbTFa-00040p-JX for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 15:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbTFa-0005TH-Cv for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Apr 2021 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48072-submit@debbugs.gnu.org id=B48072.161955118621003 (code B ref 48072); Tue, 27 Apr 2021 19:20:02 +0000 Original-Received: (at 48072) by debbugs.gnu.org; 27 Apr 2021 19:19:46 +0000 Original-Received: from localhost ([127.0.0.1]:50949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbTFK-0005Sh-7D for submit@debbugs.gnu.org; Tue, 27 Apr 2021 15:19:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbTFE-0005SR-S5 for 48072@debbugs.gnu.org; Tue, 27 Apr 2021 15:19:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57176) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbTF9-0003jx-Ei; Tue, 27 Apr 2021 15:19:35 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4141 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lbTF8-00051Z-Pi; Tue, 27 Apr 2021 15:19:35 -0400 In-Reply-To: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> (message from Boruch Baum on Tue, 27 Apr 2021 15:02:43 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205048 Archived-At: > Date: Tue, 27 Apr 2021 15:02:43 -0400 > From: Boruch Baum > > Function dired-read-shell-command was accepting an empty input. This is > a bug because it then passes the empty input as a legitimate command > which is silently processed (in error) by dired, eventually to return a > completion message. I'm not sure we want to disallow this. (Wasn't there a similar discussion recently?) > validates the entered command as a valid shell executable. This is certainly a mistake: a valid shell command doesn't have to be a file that executable-find is able to find. Shells are known to support all kinds of internal and magic commands. Thanks.