From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: jporterbugs@gmail.com, larsi@gnus.org, 49283@debbugs.gnu.org
Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows
Date: Thu, 01 Jul 2021 16:12:25 +0300 [thread overview]
Message-ID: <83lf6qkwjq.fsf@gnu.org> (raw)
In-Reply-To: <87h7hexlsv.fsf@gmx.de> (message from Michael Albinus on Thu, 01 Jul 2021 14:26:08 +0200)
> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Thu, 01 Jul 2021 14:26:08 +0200
> Cc: Jim Porter <jporterbugs@gmail.com>, 49283@debbugs.gnu.org
>
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> > - infile = Fexpand_file_name (args[1], BVAR (current_buffer, directory));
> > + infile = Fexpand_file_name (args[1], encode_current_directory ());
> > CHECK_STRING (infile);
>
> Yes, this seems TRT. encode_current_directory returns either
> default-directory if this is a local dir, or "~" otherwise. Expanding
> INFILE to that directory is OK, I believe.
>
> So we shall apply Jim's patch. Maybe the docstring could be enhanced a
> little bit at the end, saying that INFILE, if it is a relative file
> name, is expanded to the directory the process uses as cwd.
encode_current_directory returns an encoded file name. So if we make
this change, we should avoid calling ENCODE_FILE on it (doing so is a
no-op, but it's still unclean).
next prev parent reply other threads:[~2021-07-01 13:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 5:14 bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Jim Porter
2021-06-30 7:24 ` Michael Albinus
2021-06-30 17:16 ` Jim Porter
2021-07-01 11:07 ` Lars Ingebrigtsen
2021-07-01 12:26 ` Michael Albinus
2021-07-01 12:34 ` Lars Ingebrigtsen
2021-07-01 13:12 ` Eli Zaretskii [this message]
2021-07-01 19:45 ` Jim Porter
2021-07-02 6:37 ` Eli Zaretskii
2021-07-02 18:47 ` Jim Porter
2021-07-03 7:02 ` Eli Zaretskii
2021-07-04 13:32 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lf6qkwjq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49283@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=larsi@gnus.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.