From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Fri, 23 Jul 2021 22:10:28 +0300 Message-ID: <83lf5w26e3.fsf@gnu.org> References: <83h7gw6pyj.fsf@gnu.org> <45EBF16A-C953-42C7-97D1-3A2BFEF7DD01@gmail.com> <83y2a764oy.fsf@gnu.org> <83v95b60fn.fsf@gnu.org> <00DD5BFE-D14E-449A-9319-E7B725DEBFB3@gmail.com> <83r1fz5xr9.fsf@gnu.org> <1AAB1BCC-362B-4249-B785-4E0530E15C60@gmail.com> <83czri67h0.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <83eebq2mpy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 23 21:11:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m70a7-0007Vp-4r for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Jul 2021 21:11:35 +0200 Original-Received: from localhost ([::1]:42934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m70a5-0003g8-76 for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Jul 2021 15:11:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m70ZN-00030U-8d for emacs-devel@gnu.org; Fri, 23 Jul 2021 15:10:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39830) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m70ZL-0002nc-UQ; Fri, 23 Jul 2021 15:10:47 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1113 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m70ZK-0007Jg-1j; Fri, 23 Jul 2021 15:10:46 -0400 In-Reply-To: (message from Yuan Fu on Fri, 23 Jul 2021 09:25:17 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271505 Archived-At: > From: Yuan Fu > Date: Fri, 23 Jul 2021 09:25:17 -0400 > Cc: Stefan Monnier , > Clément Pit-Claudel , > emacs-devel@gnu.org > > > So what does TS do if it attempts to allocate more memory and that > > fails? Regardless, we'd need some fallback strategy, because AFAIU > > many people run with VM overcommit enabled, so the OOM killer will > > just kill the Emacs process when it asks for too much memory. > > Abort, it seems: > > static inline void *ts_malloc_default(size_t size) { > void *result = malloc(size); > if (size > 0 && !result) { > fprintf(stderr, "tree-sitter failed to allocate %zu bytes", size); > exit(1); > } > return result; > } We must replace this function, if only because the MS-Windows build of Emacs uses a custom malloc implementation. Does TS allow the client to use its own malloc? > >> Also, we don’t call change hooks in replace_range_2, why? > > > > Because it is called in a loop, one character at a time. The caller > > of replace_range_2 calls these hooks for the entire region, once. > > > >> Should I update tree-sitter trees in that function, or should I not? > > > > The only caller is casify_region, so you could update there. > > casify_region doesn’t have access to byte positions. You can compute them using CHAR_TO_BYTE. > I’ll leave it as-is, recording change in replace_range_2, if you don’t object to it. That'd be wasteful, I think. replace_range_2 is called one character at a time.