From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: tgbugs@gmail.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix hack-local-variables for find-file-literally with dos encoding
Date: Mon, 16 Aug 2021 15:29:16 +0300 [thread overview]
Message-ID: <83lf518ter.fsf@gnu.org> (raw)
In-Reply-To: <87bl5xfvjv.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 16 Aug 2021 14:01:08 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 16 Aug 2021 14:01:08 +0200
> Cc: Emacs developers <emacs-devel@gnu.org>
>
> So I think your revised patch is correct -- the `subst-char-in-region'
> thing is just plain wrong and should be removed.
You only considered the case of DOS EOL format. What about the Mac
EOL format?
More importantly, what about selective-display, which replaces
newlines with \r's? I think this replacement is for that use case.
So perhaps the condition for the replacement should be
selective-display?
next prev parent reply other threads:[~2021-08-16 12:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 21:23 [PATCH] Fix hack-local-variables for find-file-literally with dos encoding Tom Gillespie
2021-08-15 21:35 ` Tom Gillespie
2021-08-15 21:52 ` Lars Ingebrigtsen
2021-08-15 22:14 ` Lars Ingebrigtsen
2021-08-15 22:31 ` Tom Gillespie
2021-08-15 22:21 ` Tom Gillespie
2021-08-15 22:39 ` Tom Gillespie
2021-08-15 23:09 ` Tom Gillespie
2021-08-16 11:32 ` Eli Zaretskii
2021-08-16 12:01 ` Lars Ingebrigtsen
2021-08-16 12:06 ` Lars Ingebrigtsen
2021-08-16 12:29 ` Eli Zaretskii [this message]
2021-08-16 12:53 ` Lars Ingebrigtsen
2021-08-16 13:22 ` Eli Zaretskii
2021-08-16 17:44 ` Tom Gillespie
2021-08-16 17:49 ` Stefan Monnier
2021-08-16 18:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lf518ter.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=tgbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.