From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.help Subject: Re: Wrong minimum emacs version in flymake.el Date: Thu, 09 Dec 2021 17:02:51 +0200 Message-ID: <83lf0tu8h0.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12266"; mail-complaints-to="usenet@ciao.gmane.io" To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 09 16:10:51 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvL4M-0002z5-KS for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 09 Dec 2021 16:10:50 +0100 Original-Received: from localhost ([::1]:44640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvL4L-0006XS-Kp for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 09 Dec 2021 10:10:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:32924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvKx3-0004t9-Tp for help-gnu-emacs@gnu.org; Thu, 09 Dec 2021 10:03:17 -0500 Original-Received: from [2001:470:142:3::e] (port=46288 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvKww-0002Sc-3b for help-gnu-emacs@gnu.org; Thu, 09 Dec 2021 10:03:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pG4a6iqR3RAD3OY4gFu2WSkqU9PYKilHpjSSirGNyCo=; b=VfhZm/JFwkTJ OhUxxe9BcG+u+zxYaWyEllcgLMRWEzSrSZgNTH429317We/A4PlKwRKtn8Ih+MrZuxg9/NT8zzcLZ ldR5Wpm9q8iEad8vkjuUe3SCyV7btIUqWk4/Nfhk3YysCHj92eYGQoowNqTEN8avFl4JbNS0zvXci bzOqk/3qTzRCXYYgdRLrLpjwNReAOaWr+1c8qdvP7xOrC9MUwaZvaTFkhc9f4nO2x5VJ+uUQDwGRj +0OgeyQgJzUPmNRO+Lj415XH4dIEBeQ3imdcZnG00Ijbr+DDyQeQi+e2Wm8Js4RPQ/muA8V09zB89 vliUPGvGl+JvoFPfjP84aQ==; Original-Received: from [87.69.77.57] (port=2055 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvKwt-0000kz-4c for help-gnu-emacs@gnu.org; Thu, 09 Dec 2021 10:03:09 -0500 In-Reply-To: (message from Guillaume Pasquet on Thu, 9 Dec 2021 14:21:50 +0000) X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:134919 Archived-At: > From: Guillaume Pasquet > Date: Thu, 9 Dec 2021 14:21:50 +0000 > > I've notice that flymake.el in master states that it requires minimum emacs > 26.1, however this doesn't seem to be true as it makes use of the > `string-replace` function, which was introduced in Emacs 28 AFAIK. > > Please either update the minimum emacs requirement for flymake or > substitute the `string-replace` call with `replace-regexp-in-string` to > maintain compatibility as I have done here: Done, thanks.