From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: jporterbugs@gmail.com, larsi@gnus.org, 54190@debbugs.gnu.org
Subject: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes
Date: Mon, 28 Feb 2022 15:28:03 +0200 [thread overview]
Message-ID: <83lexvm87w.fsf@gnu.org> (raw)
In-Reply-To: <jwv4k4jyvvl.fsf-monnier+emacs@gnu.org> (bug-gnu-emacs@gnu.org)
> Cc: Jim Porter <jporterbugs@gmail.com>, 54190@debbugs.gnu.org
> Date: Mon, 28 Feb 2022 08:18:26 -0500
> From: Stefan Monnier via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> > diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el
> > index 96838d4132..7388279f15 100644
> > --- a/lisp/eshell/esh-var.el
> > +++ b/lisp/eshell/esh-var.el
> > @@ -463,8 +463,8 @@ eshell-parse-variable-ref
> > (eshell-as-subcommand ,(eshell-parse-command cmd))
> > (ignore
> > (nconc eshell-this-command-hook
> > - (list (function (lambda ()
> > - (delete-file ,temp))))))
> > + (list (lambda ()
> > + (delete-file ,temp)))))
> > (quote ,temp)))
> > (goto-char (1+ end)))))))
> > ((eq (char-after) ?\()
> >
> >
> > Trying to follow the logic of how this is eventually evaluated isn't,
> > er, obvious, but I'm not sure how that change could break anything,
> > either. Perhaps Stefan has a comment; added to the CCs.
>
> Looks like a bug somewhere in the `eshell-do-eval` machinery, yes.
> Until we find the problem (or rewrite `eshell-do-eval` on top of the CPS
> converter of `generator.el`), I think reverting this change (and adding
> a comment pointing to this bug) sounds like a great plan.
I agree. We should revert this on the release branch, since this is a
regression wrt Emacs 27.
Thanks.
next prev parent reply other threads:[~2022-02-28 13:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 21:34 bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes Jim Porter
2022-02-28 6:11 ` Jim Porter
2022-02-28 8:16 ` Jim Porter
2022-02-28 9:38 ` Lars Ingebrigtsen
2022-02-28 13:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-28 13:28 ` Eli Zaretskii [this message]
2022-02-28 17:47 ` Jim Porter
2022-03-01 13:10 ` Eli Zaretskii
2022-03-04 5:55 ` Jim Porter
2022-03-04 7:16 ` Eli Zaretskii
2022-03-04 13:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-04 18:04 ` Jim Porter
2022-09-06 11:28 ` Lars Ingebrigtsen
2022-09-07 3:50 ` Jim Porter
2022-09-07 3:59 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lexvm87w.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=54190@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.