From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54450: 29.0.50; redisplay--pre-redisplay-functions issue Date: Sat, 19 Mar 2022 09:22:05 +0200 Message-ID: <83lex6fluq.fsf@gnu.org> References: <87pmmjw9ru.fsf.ref@aol.com> <87pmmjw9ru.fsf@aol.com> <83sfrffb59.fsf@gnu.org> <20220318174252.xd33nalq4fdwpkeb@Ergus> <83r16zf6n9.fsf@gnu.org> <83pmmjf5x3.fsf@gnu.org> <20220318212524.53sgxqnw2a67xsfe@Ergus> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21349"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54450-done@debbugs.gnu.org To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 19 08:25:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVTTE-0005NU-U9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Mar 2022 08:25:53 +0100 Original-Received: from localhost ([::1]:35712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVTTD-00040h-HG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Mar 2022 03:25:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVTQU-0007Mt-Ss for bug-gnu-emacs@gnu.org; Sat, 19 Mar 2022 03:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVTQU-0005lJ-Iu for bug-gnu-emacs@gnu.org; Sat, 19 Mar 2022 03:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVTQU-0006dX-GW for bug-gnu-emacs@gnu.org; Sat, 19 Mar 2022 03:23:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Mar 2022 07:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 54450 X-GNU-PR-Package: emacs Mail-Followup-To: 54450@debbugs.gnu.org, eliz@gnu.org, spacibba@aol.com Original-Received: via spool by 54450-done@debbugs.gnu.org id=D54450.164767453225423 (code D ref 54450); Sat, 19 Mar 2022 07:23:02 +0000 Original-Received: (at 54450-done) by debbugs.gnu.org; 19 Mar 2022 07:22:12 +0000 Original-Received: from localhost ([127.0.0.1]:58917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVTPg-0006bz-CX for submit@debbugs.gnu.org; Sat, 19 Mar 2022 03:22:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVTPe-0006bj-M1 for 54450-done@debbugs.gnu.org; Sat, 19 Mar 2022 03:22:10 -0400 Original-Received: from [2001:470:142:3::e] (port=52798 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVTPZ-0005cu-Cn; Sat, 19 Mar 2022 03:22:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jhUxg/l9TKI4hKdLzW7RWmTIHoTZbzIJ2XXvqhUEXjU=; b=kelbTDqPbdVw R8cw4xVsjq04anZpXJP2pqmCHMNPE5X/uor47NSCTpNzlSzfuAIU/EH1hTZyx6e4ft12PSyQM0s+R NgUy1igYJjDddm01vrD74qrhma0GYa6694OyVt4ef+Olsp8pbLySB70MQSFAzJkll/aZs6pNSttBr /SYRBOHwJjVlQskBQVNWrBk2MV3pA54La2dEkC91CHTU/HEU2qNA5DwzPtACCHz5jCnqo4Ui2SwAO 3Dhx/j6QN/HD+/a8nJCQRM4TGgwPJnEi/Mgn4nkEQPZcvUXU+6fud1k2002i0n4QuVESRs/BcojcE b+gD9vVT7DhETxWI1SFwsQ==; Original-Received: from [87.69.77.57] (port=4342 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVTPY-0000TA-Pd; Sat, 19 Mar 2022 03:22:05 -0400 In-Reply-To: <20220318212524.53sgxqnw2a67xsfe@Ergus> (message from Ergus on Fri, 18 Mar 2022 22:25:24 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228581 Archived-At: > Date: Fri, 18 Mar 2022 22:25:24 +0100 > From: Ergus > Cc: 54450@debbugs.gnu.org > > On Fri, Mar 18, 2022 at 08:54:00PM +0200, Eli Zaretskii wrote: > >> Date: Fri, 18 Mar 2022 20:38:18 +0200 > >> From: Eli Zaretskii > >> Cc: 54450@debbugs.gnu.org > >> > >> > Yes, this could solve the issue for the region, but not in general for > >> > redisplay--update-cursor-face-highlight which was the initial problem > >> > with Juri's code. Same for any other function that goes into the > >> > pre-redisplay-functions hook. > >> > >> I asked for a test case, and this is what you gave me. > >> > >> If there's another test case, please show it. > > > >But before you do, please try the alternative patch below: > > > >diff --git a/src/xdisp.c b/src/xdisp.c > >index 5cb5839..6d8d4aa 100644 > >--- a/src/xdisp.c > >+++ b/src/xdisp.c > >@@ -13211,7 +13211,8 @@ prepare_menu_bars (void) > > struct window *w = XWINDOW (this); > > if (w->redisplay > > || XFRAME (w->frame)->redisplay > >- || XBUFFER (w->contents)->text->redisplay) > >+ || XBUFFER (w->contents)->text->redisplay > >+ || w->last_point != marker_position (w->pointm)) > > { > > windows = Fcons (this, windows); > > } > > Yes, now this seems to solve the issue for the two use cases described. Thanks, I installed a slightly modified variant of this on the emacs-28 branch.