From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase Date: Fri, 10 Jun 2022 18:58:05 +0300 Message-ID: <83leu4zf1u.fsf@gnu.org> References: <37af046b-4257-6370-c765-9290eae73fd4@gmail.com> <831qw6dzra.fsf@gnu.org> <0278e759-237b-a32b-4b1f-fbdacf39c8ef@gmail.com> <83pmjpar0x.fsf@gnu.org> <9e8a8b42-2f42-3027-2ec0-97744bb91911@gmail.com> <83sfoja2xp.fsf@gnu.org> <34062848-8fe4-351c-df63-5cc341fefa57@gmail.com> <83sfoj7x6f.fsf@gnu.org> <83ee027yjc.fsf@gnu.org> <2b86123e-76c1-ec0c-c767-7d821473e5e1@gmx.at> <86a0c66e-86f9-6bd6-2010-eb1cf2d9f1e6@gmail.com> <83a6am47v6.fsf@gnu.org> <4abda9a0-7c34-cdad-fc9e-a6dc25e7c74b@gmail.com> <837d5p3hr7.fsf@gnu.org> <8e4fc184-8ca1-8094-f37d-f77d0cbb337c@gmail.com> <83edzx12vm.fsf@gnu.org> <6c0578d4-4060-3c81-584e-53eb9912d40e@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27696"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 10 17:59:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzh2U-00073U-Fr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jun 2022 17:59:10 +0200 Original-Received: from localhost ([::1]:41892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzh2T-0000Jj-EN for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jun 2022 11:59:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzh2L-0000JS-WC for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 11:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57183) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzh2L-0005mc-OP for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 11:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzh2L-0002p3-OB for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 11:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jun 2022 15:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55696 X-GNU-PR-Package: emacs Original-Received: via spool by 55696-submit@debbugs.gnu.org id=B55696.165487670010804 (code B ref 55696); Fri, 10 Jun 2022 15:59:01 +0000 Original-Received: (at 55696) by debbugs.gnu.org; 10 Jun 2022 15:58:20 +0000 Original-Received: from localhost ([127.0.0.1]:51080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzh1g-0002oC-Dn for submit@debbugs.gnu.org; Fri, 10 Jun 2022 11:58:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzh1Z-0002ns-7q for 55696@debbugs.gnu.org; Fri, 10 Jun 2022 11:58:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57006) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzh1T-0005iC-SK; Fri, 10 Jun 2022 11:58:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=20TyTRT1FASmywyHAx/c9GrhdjdpkOTnke/eaa6YZcA=; b=NEFpxZLqjL2R ImSZanRxLBsvt1LonHnyK8yFW/YgG6xBOjjkVQOH6wfWoUXI6tasbLKXDM+m1QIjUQu9BGQ28dnoT kmIb3jG+5QdV4r8zsRi9cRZGEpqaxYYBMSwxUVQO+Ub3rWJObpymxSu6wJR8cwOaW+tzDvqVGNAzW Z53Ht5G7ve/XZyrJVmkZZwAK33V3ZRY5GbhZN3VpXod7XHuN3/QrX6Ovv28gdH6HBu9Elu3Eox3S7 ZETGVceUeurUG51E487VkLGCiFDq/NX9pyX+3IGMluBFLu2KjjBBTUYrZeZ2r8irROccI6XymaRcC zwQBLKahZT2DHN0GPLLwtg==; Original-Received: from [87.69.77.57] (port=1263 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzh1T-0008Dx-Bs; Fri, 10 Jun 2022 11:58:07 -0400 In-Reply-To: <6c0578d4-4060-3c81-584e-53eb9912d40e@gmail.com> (message from Jim Porter on Fri, 10 Jun 2022 08:44:22 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234231 Archived-At: > Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com > From: Jim Porter > Date: Fri, 10 Jun 2022 08:44:22 -0700 > > On 6/9/2022 10:52 PM, Eli Zaretskii wrote: > > What if there's an external command named 'listify' -- is there any > > chance that the test will invoke it? If so, I think we should come up > > with a safer solution. > > No, that shouldn't be a problem. When Eshell executes something that > looks like a shell command[1], the order of precedence is this: > > 1. If an alias for the command exists in .emacs.d/eshell/aliases, use > that. (This won't happen in tests, since `eshell-test-command-result' > binds `eshell-directory-name' to a temp dir.) > > 2. If there's a Lisp function named `eshell/COMMAND', use that. > > 3. If there's an external command named `COMMAND', use that. > > 4. If there's a Lisp function named `COMMAND', use that. So the problem with using 'list' was that there was no Lisp function eshell/list, is that right? > > Otherwise, feel free to install the change, and thanks. > > Thanks. (I don't have direct commit access, so hopefully you or someone > else with commit access can install it when you/they get the chance.) Done.