From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master c12838c73e: * lisp/help-fns.el: Minor fixes Date: Sat, 03 Sep 2022 10:27:44 +0300 Message-ID: <83ler0or2n.fsf@gnu.org> References: <166212688020.22107.2630550400639665135@vcs2.savannah.gnu.org> <20220902135440.B28DFC04F05@vcs2.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4777"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 03 09:29:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUNaw-00015z-3f for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Sep 2022 09:29:34 +0200 Original-Received: from localhost ([::1]:51546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUNav-0007VB-6n for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Sep 2022 03:29:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUNZh-000683-S9 for emacs-devel@gnu.org; Sat, 03 Sep 2022 03:28:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUNZg-00052K-S2; Sat, 03 Sep 2022 03:28:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WdGh6BTozB7PBFHRzgLOBnRxP0cA1lgUIAP95uO4Spw=; b=dbWwMlDM8Ccp QQxEl7+ySAazImniZilJ+iorgcr4/k8yKQ0O0/Vijk8+XjmHiwnrR8sZJlNww1CdrBCSmVwkjRPgg LHK4idbpiVVrPrELSrm1v3Tr+0WqZV/NQy0F25UBt4+Rmws/hUMCHhSUWZr3pdKIdEKetQ6/BaP7n 5UykkWwYU7W5glC9/iIzlBBHSGQhNkGhE5JNA62xEfDav4yMkYyUdSrM90KLqsTsTbUP0d1FQdV/J +XYAIgmpmHR6Ewv6zYR0gUEBYjCPDKgRAu2QvGNeSO/e7L5hx/fyu3w/pnH9fujq7NQAzeIXsBzCg YstkM1TM5CgY8xYkKk6yog==; Original-Received: from [87.69.77.57] (port=2247 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUNZb-0003EZ-WC; Sat, 03 Sep 2022 03:28:16 -0400 In-Reply-To: (message from Stefan Kangas on Fri, 2 Sep 2022 17:44:30 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294614 Archived-At: > From: Stefan Kangas > Date: Fri, 2 Sep 2022 17:44:30 -0700 > > > branch: master > > commit c12838c73ef161850a081f9ccea6e375b7c2f93b > > Author: Stefan Monnier > > Commit: Stefan Monnier > > > > * lisp/help-fns.el: Minor fixes > > > > (describe-mode--minor-modes): Don't burp on minor modes that lack a docstring. > > (describe-mode--minor-modes): Simplify eta-redex. > > (find-lisp-object-file-name): Use `autoload-file`. > > (help-fns--describe-function-or-command-prompt): Allow the user to > > insist on choosing a function even if it appears not to exist. > > This seems to lead to: > > Test help-fns-test-bug17410 backtrace: > autoload-file((autoload "foo" nil nil t)) > find-lisp-object-file-name(help-fns-test--macro (autoload "foo" nil Yes, because the function autoload-file doesn't seem to exist.